From: Chris Mason <chris.mason@oracle.com>
To: Eugene Teo <eugeneteo@kernel.sg>
Cc: Yan Zheng <zheng.yan@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Btrfs: setting variable out of order
Date: Wed, 15 Apr 2009 08:59:05 -0400 [thread overview]
Message-ID: <1239800345.31633.1.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20090415091126.GA13323@kernel.sg>
On Wed, 2009-04-15 at 17:11 +0800, Eugene Teo wrote:
> This doesn't look intentional.
>
> Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
> ---
> fs/btrfs/ctree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index e5b2533..6aa2468 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
> btrfs_trans_handle *trans,
> for (i = 0; i < nr; i++) {
> if (total_size + data_size[i] + sizeof(struct btrfs_item) >
> BTRFS_LEAF_DATA_SIZE(root)) {
> - break;
> nr = i;
> + break;
> }
Thanks,
This function isn't used anymore, I'll drop it.
-chris
prev parent reply other threads:[~2009-04-15 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 9:11 [PATCH] Btrfs: setting variable out of order Eugene Teo
2009-04-15 12:59 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239800345.31633.1.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=eugeneteo@kernel.sg \
--cc=linux-kernel@vger.kernel.org \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox