Re: sparc: struct device - replace bus_id with dev_name(), dev_set_name()

David Miller
2009-04-16T22:57:09Z

Date: Thu, 16 Apr 2009 18:21:52 +0200

> On Fri, 2009-03-27 at 17:27 -0700, David Miller wrote:
>> From: Kay Sievers <kay.sievers@vrfy.org>
>> Date: Fri, 27 Mar 2009 13:21:56 +0100
>>
>> > it took a while, but it happened now, so this issue is coming back. :)
>> >
>> > The name size limit is gone, there is no BUS_ID_SIZE thing anymore in
>> > the driver core. BUS_ID_SIZE should go away in the 2.6.30 timeframe.
>> >
>> > Could you please convert/remove BUS_ID_SIZE value from:
>> > drivers/net/gianfar.h: char phy_bus_id[BUS_ID_SIZE];
>> > drivers/net/ucc_geth.h: char phy_bus_id[BUS_ID_SIZE];
>> > drivers/net/pasemi_mac.h: char phy_id[BUS_ID_SIZE];
>> > include/linux/phy.h:#define MII_BUS_ID_SIZE (BUS_ID_SIZE - 3)
>> > include/linux/phy.h: char bus_id[BUS_ID_SIZE];
>> >
>> > Or let me know how you want to convert it, so I can do it?
>>
>> Thanks a lot Kay, I'll look into these cases and take care
>> of it.
>
> This moves the 20 into the netdevice header, we need to get rid
> of the driver core define now, otherwise people start adding new
> code using it, and we want to finish this thankless job finally. :)

I was working on fixing this properly Kay, please be patient.

I'll have it killed off in net-next-2.6 soon enough.