Re: RFC: introduce struct ksymbol

Ingo Molnar
2009-04-15T05:59:24Z

(Sam and Rusty Cc:-ed)

* Joe Perches <joe@perches.com> wrote:

> On Wed, 2009-04-15 at 02:00 +0200, Frederic Weisbecker wrote:
> > arch/blackfin/kernel/traps.c: symname = kallsyms_lookup(address, &symsize, &offset, &modname, namebuf);
> > arch/powerpc/xmon/xmon.c: name = kallsyms_lookup(pc, &size, &offset, NULL, tmpstr);
> > arch/sh/kernel/cpu/sh5/unwind.c: sym = kallsyms_lookup(pc, NULL, &offset, NULL, namebuf);
> > arch/x86/kernel/ftrace.c: kallsyms_lookup((unsigned long) syscall, NULL, NULL, NULL, str);
> > kernel/kprobes.c: sym = kallsyms_lookup((unsigned long)p->addr, NULL,
> > kernel/lockdep.c: return kallsyms_lookup((unsigned long)key, NULL, NULL, NULL, str);
> > kernel/trace/ftrace.c: kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);
> > kernel/trace/ftrace.c: kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);
> > kernel/trace/ftrace.c: kallsyms_lookup((unsigned long)rec->ops->func, NULL, NULL, NULL, str);
> > kernel/trace/ftrace.c: kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);
> > kernel/trace/ftrace.c: kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);
> > kernel/trace/ftrace.c: kallsyms_lookup(rec->ip, NULL, NULL, &modname, str);
> > kernel/trace/ftrace.c: kallsyms_lookup(*ptr, NULL, NULL, NULL, str);
> > kernel/trace/trace_functions.c: kallsyms_lookup(ip, NULL, NULL, NULL, str);
> > kernel/trace/trace_output.c: kallsyms_lookup(address, NULL, NULL, NULL, str);
>
> Perhaps a conversion from
>
> "char str[KSYM_SYMBOL_LEN]"
> to
> "struct ksymbol sym"?
>
> could be useful.
>
> There are a few places that use a hard coded length of 128
> instead of KSYM_SYMBOL_LENGTH that are also converted.
>
> Compile tested only

Why not 'struct ksym'? That name is unused right now, it is shorter
and just as descriptive.

Regarding the change... dunno. Sam, Rusty - what do you think?

Downsides would be loss of awareness of stack footprint impact. A
plain struct is easy to slap on, and it's not immediately visible
that it carries 128 bytes of weight. It might also be confusing in
terms of the nature of the interface - whether it's a pointery
object or not.

Prior use:

char str[KSYM_SYMBOL_LEN];

kallsyms_lookup(rec->ip, NULL, NULL, NULL, str);

New use:

struct ksym sym;

kallsyms_lookup(rec->ip, NULL, NULL, NULL, &sym);

Dunno.

Ingo