public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Christoph Lameter <cl@linux.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: Scheduler regression: Too frequent timer interrupts(?)
Date: Fri, 17 Apr 2009 16:51:41 +0200	[thread overview]
Message-ID: <1239979901.23397.4638.camel@laptop> (raw)
In-Reply-To: <alpine.DEB.1.10.0904171021360.20239@qirst.com>

On Fri, 2009-04-17 at 10:29 -0400, Christoph Lameter wrote:

> > With something like that you could say, the jiffy tick went from 0.8+-.1
> > to 1.1+-.1 us or somesuch.
> 
> Well yeah we can look at this but there seem to be regressions in a lot of
> other subsystems as well. Rescheduling is another thing that we tracked.
> Its interesting that the holdoffs varied at lot during the scheduler
> transition to CFS and then stayed high after that was complete.
> 
> > After that, you could possibly use oprofile or readprofile or
> > perf-counters to get an idea where the time is spend. I did a quick
> > profile on one of my machines, and about half the kernel time spend in a
> > while(1) loop comes from __do_softirq().
> >
> > Really, I should not have to tell you this...
> 
> I can get down there but do you really want me to start hacking on the
> scheduler again? This seems to be a regression from what we had working
> fine before.

I won't mind you sending patches. But really, the first thing to do is
figuring out what is taking time.

And a random 1us cutoff, is well, random.

If you want to reduce interrupts, that's fine, but not counting an
interrupt because its below the magic 1us marker sounds a bit, well,
magic -- might work for you, might not for me on another machine, might
even be compiler dependent.

So 5 <1us interruption are not at all accounted, whereas a single 1>us
interruption is. I'd rather get rid of those 5 than try and shave a bit
of the one, if you get what I mean.

I'm pretty sure if we run the current kernel on a 5GHz machine all
interrupts are under 1us again :-), problem fixed? I don't think so.

Furthermore, yes the scheduler is one of those jiffy tick users, but
there are more. We can do ntp/gtod things in there, there is process
accounting, there is some RCU machinery, timers etc..

Like said, I did a profile on current -tip and __do_softirq was about
half the time spend in kernel. I'm not sure why it would be, maybe we're
doing tons of cache misses there for some reason, I dunno.




  reply	other threads:[~2009-04-17 14:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 19:53 Scheduler regression: Too frequent timer interrupts(?) Christoph Lameter
2009-04-17  7:00 ` Peter Zijlstra
2009-04-17 13:42   ` Christoph Lameter
2009-04-17 14:16     ` Peter Zijlstra
2009-04-17 14:29       ` Christoph Lameter
2009-04-17 14:51         ` Peter Zijlstra [this message]
2009-04-17 15:04           ` Christoph Lameter
2009-04-17 15:28             ` Peter Zijlstra
2009-04-23  4:42               ` Pavel Machek
2009-04-28 21:02                 ` Christoph Lameter
2009-04-28 21:23                   ` Peter Zijlstra
2009-04-28 21:21                     ` Christoph Lameter
2009-04-17 15:35             ` Ingo Molnar
2009-04-17 15:55               ` Christoph Lameter
2009-04-17 16:23                 ` Peter Zijlstra
2009-04-17 16:33                   ` Christoph Lameter
2009-04-17 16:49                   ` Ingo Molnar
2009-04-17 17:19                     ` Chris Friesen
2009-04-17 17:45                     ` Christoph Lameter
2009-04-17 18:11                       ` Peter Zijlstra
2009-04-17 18:20                         ` Christoph Lameter
2009-04-17 18:58                           ` Peter Zijlstra
2009-04-17 20:34                             ` Christoph Lameter
2009-04-17 20:53                               ` Peter Zijlstra
2009-04-17 23:24                           ` Chris Friesen
2009-04-18  7:35                             ` Ingo Molnar
2009-04-18  7:59                             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239979901.23397.4638.camel@laptop \
    --to=peterz@infradead.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox