From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762276AbZDQSCd (ORCPT ); Fri, 17 Apr 2009 14:02:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759294AbZDQSCY (ORCPT ); Fri, 17 Apr 2009 14:02:24 -0400 Received: from hera.kernel.org ([140.211.167.34]:40552 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758939AbZDQSCY (ORCPT ); Fri, 17 Apr 2009 14:02:24 -0400 Subject: Re: [git-pull -tip] x86: fix section mismatch warnings From: Jaswinder Singh Rajput To: Ingo Molnar Cc: Sam Ravnborg , x86 maintainers , LKML In-Reply-To: <20090417164141.GJ8253@elte.hu> References: <1239918902.10567.22.camel@ht.satnam> <20090417164141.GJ8253@elte.hu> Content-Type: text/plain Date: Fri, 17 Apr 2009 23:31:20 +0530 Message-Id: <1239991281.3153.4.camel@ht.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-04-17 at 18:41 +0200, Ingo Molnar wrote: > * Jaswinder Singh Rajput wrote: > > > The following changes since commit 88dc4c8e38d64db32907e0bd605f8c1ec4c4d1bd: > > Ingo Molnar (1): > > Merge branch 'tracing/ftrace' > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git master > > > > Jaswinder Singh Rajput (3): > > x86: mm/numa_32.c calculate_numa_remap_pages should use __init > > x86: apic/es7000_32.c find_unisys_acpi_oem_table and es7000_acpi_madt_oem_check should use __init > > x86: smpboot.c wakeup_secondary_cpu_via_nmi do not required __devinit > > The commit logs lack analysis. The suggestions in the warnings are > advisory and can be wrong. Analysis explaining what happened, maybe > even when it happened, and what should be done about it to fix that > issue is needed in such changelogs. > > The commits might be correct - or they might be bogus. The commit > logs dont give us any help in deciding that. I.e. if you did that > work, you should document it. If you _didnt_ do that analysis work, > you shouldnt send patches addressing these types of warnings. > I was busy in another stuff, So I am sending analysis of first commit. If you want you can apply this patch and ignore others : [PATCH-tip] x86: mm/numa_32.c calculate_numa_remap_pages should use __init calculate_numa_remap_pages() is called only by __init initmem_init() further calculate_numa_remap_pages is calling: __init find_e820_area() and __init reserve_early() So calculate_numa_remap_pages() should be __init calculate_numa_remap_pages(). Impact: fix Section mismatch warnings WARNING: arch/x86/built-in.o(.text+0x82ea3): Section mismatch in reference from the function calculate_numa_remap_pages() to the function .init.text:find_e820_area() The function calculate_numa_remap_pages() references the function __init find_e820_area(). This is often because calculate_numa_remap_pages lacks a __init annotation or the annotation of find_e820_area is wrong. WARNING: arch/x86/built-in.o(.text+0x82f5f): Section mismatch in reference from the function calculate_numa_remap_pages() to the function .init.text:reserve_early() The function calculate_numa_remap_pages() references the function __init reserve_early(). This is often because calculate_numa_remap_pages lacks a __init annotation or the annotation of reserve_early is wrong. Signed-off-by: Jaswinder Singh Rajput --- arch/x86/mm/numa_32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c index 3daefa0..d253006 100644 --- a/arch/x86/mm/numa_32.c +++ b/arch/x86/mm/numa_32.c @@ -257,7 +257,7 @@ void resume_map_numa_kva(pgd_t *pgd_base) } #endif -static unsigned long calculate_numa_remap_pages(void) +static __init unsigned long calculate_numa_remap_pages(void) { int nid; unsigned long size, reserve_pages = 0; -- 1.6.0.6