public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: Hans de Goede <hdegoede@redhat.com>,
	markgross@kernel.org, platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] Preparations for fixing WMI reprobing issue
Date: Wed, 25 Oct 2023 12:52:50 +0300 (EEST)	[thread overview]
Message-ID: <123de6d2-fa8-ad7f-fac-9750a8a1358@linux.intel.com> (raw)
In-Reply-To: <20231020211005.38216-1-W_Armin@gmx.de>

On Fri, 20 Oct 2023, Armin Wolf wrote:

> This patch series contains preparations for fixing the WMI reprobing
> issue discussed here:
> 
> https://lkml.kernel.org/1252c8fb-8d5f-98ad-b24a-5fabec2e1c8b@gmx.de
> 
> It mainly aims to decouple some parts of the WMI subsystem from the
> wmi_block_list, which is going to get replaced in the future. It also
> fixes some issues, like a probe failure when failing to register WMI
> devices and a potential issue when opening the wmi char device.
> 
> The changes where tested on a Dell Inspiron 3505, a Lenovo E51-80,
> a Acer Aspire E1-731 and a Asus PRIME B650-Plus motherboard and appear
> to work, but additional feedback especially on the third patch
> is appreciated.
> 
> Changes since v2:
> - Drop already merged first patch
> - break the paragraphs of the second patch with an empty line
> 
> Armin Wolf (5):
>   platform/x86: wmi: Decouple probe deferring from wmi_block_list
>   platform/x86: wmi: Fix refcounting of WMI devices in legacy functions
>   platform/x86: wmi: Fix probe failure when failing to register WMI
>     devices
>   platform/x86: wmi: Fix opening of char device
>   platform/x86: wmi: Decouple WMI device removal from wmi_block_list
> 
>  drivers/platform/x86/wmi.c | 263 ++++++++++++++++++++++---------------
>  1 file changed, 157 insertions(+), 106 deletions(-)

I've now applied these into review-ilpo branch.

I adjusted the long blocks of text in the changelogs. In the future, if 
you have a changelog that is longer than ~4 lines, please try to split the 
problem description and solution into separate paragraphs as it makes the 
changelog less heavy to read.

-- 
 i.


      parent reply	other threads:[~2023-10-25  9:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 21:10 [PATCH v2 0/5] Preparations for fixing WMI reprobing issue Armin Wolf
2023-10-20 21:10 ` [PATCH v2 1/5] platform/x86: wmi: Decouple probe deferring from wmi_block_list Armin Wolf
2023-10-20 21:10 ` [PATCH v2 2/5] platform/x86: wmi: Fix refcounting of WMI devices in legacy functions Armin Wolf
2023-10-20 21:10 ` [PATCH v2 3/5] platform/x86: wmi: Fix probe failure when failing to register WMI devices Armin Wolf
2023-10-20 21:10 ` [PATCH v2 4/5] platform/x86: wmi: Fix opening of char device Armin Wolf
2023-10-20 21:10 ` [PATCH v2 5/5] platform/x86: wmi: Decouple WMI device removal from wmi_block_list Armin Wolf
2023-10-25  9:52 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=123de6d2-fa8-ad7f-fac-9750a8a1358@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=W_Armin@gmx.de \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox