Re: [PATCH v2 0/5] Preparations for fixing WMI reprobing issue

Ilpo Järvinen
2023-10-25T09:53:04Z

On Fri, 20 Oct 2023, Armin Wolf wrote:

> This patch series contains preparations for fixing the WMI reprobing
> issue discussed here:
>
> https://lkml.kernel.org/1252c8fb-8d5f-98ad-b24a-5fabec2e1c8b@gmx.de
>
> It mainly aims to decouple some parts of the WMI subsystem from the
> wmi_block_list, which is going to get replaced in the future. It also
> fixes some issues, like a probe failure when failing to register WMI
> devices and a potential issue when opening the wmi char device.
>
> The changes where tested on a Dell Inspiron 3505, a Lenovo E51-80,
> a Acer Aspire E1-731 and a Asus PRIME B650-Plus motherboard and appear
> to work, but additional feedback especially on the third patch
> is appreciated.
>
> Changes since v2:
> - Drop already merged first patch
> - break the paragraphs of the second patch with an empty line
>
> Armin Wolf (5):
> platform/x86: wmi: Decouple probe deferring from wmi_block_list
> platform/x86: wmi: Fix refcounting of WMI devices in legacy functions
> platform/x86: wmi: Fix probe failure when failing to register WMI
> devices
> platform/x86: wmi: Fix opening of char device
> platform/x86: wmi: Decouple WMI device removal from wmi_block_list
>
> drivers/platform/x86/wmi.c | 263 ++++++++++++++++++++++---------------
> 1 file changed, 157 insertions(+), 106 deletions(-)

I've now applied these into review-ilpo branch.

I adjusted the long blocks of text in the changelogs. In the future, if
you have a changelog that is longer than ~4 lines, please try to split the
problem description and solution into separate paragraphs as it makes the
changelog less heavy to read.

--
i.