From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3287721CC44 for ; Fri, 28 Nov 2025 16:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764345903; cv=none; b=BU8YevMIp5tKlZCIrX3mgPsoylI2HmCPuEoLGFiqZvtypfZu17PqAVXUPqmO5izUn+4W7yanOVztpwUCIoToZK6T6DkNVGgHHANJfVur3lnoIj2IIlp+gK7izNwBM3TsFVMKokZfHdiG6FMv2GWluyjurHlajkPv1tgvQ47ZHiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764345903; c=relaxed/simple; bh=3QLK8JIJvkJT47nt6Y+wOWoVhNKf+gXbNFhrZJ+9LPQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KLHWMrznfs3J3kTr3QgHmvnDGQbbOLgWxqJl+AIlrm6O7lCuY7tLiwcnsjipY2MPUVIRDwefJHXj18wt7RiFPWHo5zRbMt52M9XfWDHTR/39wbeiJaLwiqSA1SA1apPoZkrv5lkKPXOmwsg9e2o1RdkaBwP0qhZakL5wj3fE4ME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jj3fftO2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jj3fftO2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16639C4CEFB; Fri, 28 Nov 2025 16:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764345900; bh=3QLK8JIJvkJT47nt6Y+wOWoVhNKf+gXbNFhrZJ+9LPQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Jj3fftO2wyp2Hiclw9912EhI7L+pKeuEMMKKgqihIgQWf8RZ2eK8gnhis4jlJPmTA Cmx2sBivmv72A8YPRHEHpyd1GLhiqJ17jAH3cH+jUJiTLec0bioy5/TgLFwscbdNQ0 4MVHc8qD5xGyg4/oGrv1KUrHQi9oIiJMtPjwXTtted++ACEYpuR8uboPZbBexbWUh1 cTnvaAY9yBFr6WlCmfXHOmOCgmORHdt99kHGRcVCjj2Ii023yka2c4niEFEC4lFbUN FDV6ISXqSUn/KQPasQuCfyyvZxZTsD/RNMFa3Ju6/tZnF+e+doUSKo+t+NXroddk7a Pvv3sbc2Wj/0Q== Message-ID: <123e0d99-ef29-4906-828a-9dfd29dafd29@kernel.org> Date: Fri, 28 Nov 2025 17:04:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/memory hotplug/unplug: Optimize zone->contiguous update when move pfn range To: "Li, Tianyou" , Oscar Salvador , Mike Rapoport , Wei Yang Cc: linux-mm@kvack.org, Yong Hu , Nanhai Zou , Yuan Liu , Tim Chen , Qiuxu Zhuo , Yu C Chen , Pan Deng , Chen Zhang , linux-kernel@vger.kernel.org References: <20251119114252.oykrczprf3ecd7ak@master> <20251119140657.3845818-1-tianyou.li@intel.com> <872562fa-5dd7-4cc9-82ab-5b7c09ee8fe3@kernel.org> <9b6e39ae-c317-4433-8171-0927bce3acad@intel.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <9b6e39ae-c317-4433-8171-0927bce3acad@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit > > Instead of a bool value, could the clear_zone_contiguous_for_growing > and clear_zone_contiguous_for_shrinking return a enum value to indicate > one of the three states: 1. DEFINITELY_CONTIGUOUS; > 2. DEFINITELY_NOT_CONTIGUOUS; 3. UNDETERMINED_CONTIGUOUS? The > set_zone_contiguous took the state and skip the contiguous check if > DEFINITELY_CONTIGUOUS or DEFINITELY_NOT_CONTIGUOUS. I had the exact same thought while writing my rely, so it's worth investigating. If that helps to come up with even better+descriptive variable/function names, even better :) -- Cheers David