Re: dma-debug: add a check dma memory leaks

[David Woodhouse <dwmw2@infradead.org>]

On Mon, 2009-03-30 at 21:01 +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/linus/41531c8f5f05aba5ec645d9770557eedbf75b422
> Commit:     41531c8f5f05aba5ec645d9770557eedbf75b422

>     dma-debug: add a check dma memory leaks
>     
>     Impact: allow architectures to monitor busses for dma mem leakage
>     
>     This patch adds checking code to detect if a device has pending DMA
>     operations when it is about to be unbound from its device driver.
>     
>     Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>


> +static int dma_debug_device_change(struct notifier_block *nb,
> +				    unsigned long action, void *data)
> +{
> +	struct device *dev = data;
> +	int count;
> +
> +
> +	switch (action) {
> +	case BUS_NOTIFY_UNBIND_DRIVER:
> +		count = device_dma_allocations(dev);
> +		if (count == 0)
> +			break;
> +		err_printk(dev, NULL, "DMA-API: device driver has pending "
> +				"DMA allocations while released from device "
> +				"[count=%d]\n", count);

Hm, cute... but not quite functioning as you intended. If you look at
__device_release_driver() in drivers/base/dd.c you'll see it actually
calls the notifier _before_ calling into the driver's ->remove() method.
So it's hardly surprising that not everything has been freed yet...

Reported by Reinette when it bit iwlwifi.

Ben, can we get away with changing the order so that the ->remove() is
called before the notifier, in this case? 

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation