public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org, bzolnier@gmail.com
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 04/14] block: cleanup REQ_SOFTBARRIER usages
Date: Wed, 22 Apr 2009 01:37:51 +0900	[thread overview]
Message-ID: <1240331881-28218-5-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1240331881-28218-1-git-send-email-tj@kernel.org>

blk_insert_request() doesn't need to worry about REQ_SOFTBARRIER.
Don't set it.  Combined with recent ide updates, REQ_SOFTBARRIER is
now only used in elevator proper and for discard requests.

[ Impact: cleanup ]

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 block/blk-core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index bcc85ec..c632e6d 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -944,7 +944,6 @@ void blk_insert_request(struct request_queue *q, struct request *rq,
 	 * barrier
 	 */
 	rq->cmd_type = REQ_TYPE_SPECIAL;
-	rq->cmd_flags |= REQ_SOFTBARRIER;
 
 	rq->special = data;
 
-- 
1.6.0.2


  parent reply	other threads:[~2009-04-21 16:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21 16:37 [GIT PATCH linux-2.6-block] block: cleanup patches, take#3 Tejun Heo
2009-04-21 16:37 ` [PATCH 01/14] block: merge blk_invoke_request_fn() into __blk_run_queue() Tejun Heo
2009-04-21 16:37 ` [PATCH 02/14] block: kill blk_start_queueing() Tejun Heo
2009-04-21 16:37 ` [PATCH 03/14] block: don't set REQ_NOMERGE unnecessarily Tejun Heo
2009-04-21 16:37 ` Tejun Heo [this message]
2009-04-21 16:37 ` [PATCH 05/14] block: clean up misc stuff after block layer timeout conversion Tejun Heo
2009-04-21 16:37 ` [PATCH 06/14] block: reorder request completion functions Tejun Heo
2009-04-21 16:37 ` [PATCH 07/14] block: reorganize request fetching functions Tejun Heo
2009-04-21 17:07   ` Christoph Hellwig
2009-04-22 10:09     ` Jens Axboe
2009-04-23  1:23       ` Tejun Heo
2009-04-21 16:37 ` [PATCH 08/14] block: kill blk_end_request_callback() Tejun Heo
2009-04-21 16:37 ` [PATCH 09/14] block: clean up request completion API Tejun Heo
2009-04-21 17:59   ` Christoph Hellwig
2009-04-23  1:24     ` Tejun Heo
2009-04-23  2:08       ` [PATCH UPDATED " Tejun Heo
2009-04-23  9:43         ` Boaz Harrosh
2009-04-23  9:59           ` Tejun Heo
2009-04-21 16:37 ` [PATCH 10/14] block: move rq->start_time initialization to blk_rq_init() Tejun Heo
2009-04-21 16:37 ` [PATCH 11/14] block: implement and use [__]blk_end_request_all() Tejun Heo
2009-04-21 16:37 ` [PATCH 12/14] block: replace end_request() with [__]blk_end_request_cur() Tejun Heo
2009-04-21 18:25   ` Joerg Dorchain
2009-04-21 20:35   ` Laurent Vivier
2009-04-22  9:25   ` Geert Uytterhoeven
2009-04-22 16:04   ` Grant Likely
2009-04-21 16:38 ` [PATCH 13/14] block: don't abuse rq->data Tejun Heo
2009-04-21 16:38 ` [PATCH 14/14] block-kill-data Tejun Heo
2009-04-21 16:42   ` [PATCH 14/14] block: kill rq->data Tejun Heo
2009-04-22 10:10 ` [GIT PATCH linux-2.6-block] block: cleanup patches, take#3 Jens Axboe
2009-04-23  2:10   ` Tejun Heo
2009-04-23  6:09     ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2009-03-13  5:02 [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-13  5:02 ` [PATCH 04/14] block: cleanup REQ_SOFTBARRIER usages Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240331881-28218-5-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bzolnier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox