From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org,
joerg@dorchain.net, geert@linux-m68k.org, donari75@gmail.com,
davem@davemloft.net, jdike@linux.intel.com,
benh@kernel.crashing.org, Laurent@lvivier.info
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 04/12] ps3disk: simplify request completion
Date: Thu, 23 Apr 2009 21:25:45 +0900 [thread overview]
Message-ID: <1240489553-15724-5-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1240489553-15724-1-git-send-email-tj@kernel.org>
ps3disk_interrupt() always completes requests fully but it uses
rq->hard_cur_sectors for FLUSH requests for some reason. Drop them
and simply use __blk_end_request_all().
[ Impact: cleanup ]
Signed-off-by: Tejun Heo <tj@kernel.org>
---
drivers/block/ps3disk.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
index d23b54b..f6586e4 100644
--- a/drivers/block/ps3disk.c
+++ b/drivers/block/ps3disk.c
@@ -231,7 +231,6 @@ static irqreturn_t ps3disk_interrupt(int irq, void *data)
struct request *req;
int res, read, error;
u64 tag, status;
- unsigned long num_sectors;
const char *op;
res = lv1_storage_get_async_status(dev->sbd.dev_id, &tag, &status);
@@ -261,11 +260,9 @@ static irqreturn_t ps3disk_interrupt(int irq, void *data)
if (req->cmd_type == REQ_TYPE_LINUX_BLOCK &&
req->cmd[0] == REQ_LB_OP_FLUSH) {
read = 0;
- num_sectors = req->hard_cur_sectors;
op = "flush";
} else {
read = !rq_data_dir(req);
- num_sectors = req->nr_sectors;
op = read ? "read" : "write";
}
if (status) {
@@ -281,7 +278,7 @@ static irqreturn_t ps3disk_interrupt(int irq, void *data)
}
spin_lock(&priv->lock);
- __blk_end_request(req, error, num_sectors << 9);
+ __blk_end_request_all(req, error);
priv->req = NULL;
ps3disk_do_request(dev, priv->queue);
spin_unlock(&priv->lock);
--
1.6.0.2
next prev parent reply other threads:[~2009-04-23 12:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 12:25 [RFC PATCHSET linux-2.6-block#for-2.6.31] block: lld cleanup patches Tejun Heo
2009-04-23 12:25 ` [PATCH 01/12] block-update-end_cur Tejun Heo
2009-04-23 12:25 ` [PATCH 02/12] block: don't init rq fields unnecessarily Tejun Heo
2009-04-23 12:25 ` [PATCH 03/12] amiflop,ataflop,xd,mg_disk: clean up unnecessary stuff from block drivers Tejun Heo
2009-04-23 12:25 ` Tejun Heo [this message]
2009-04-23 12:25 ` [PATCH 05/12] sunvdc: kill vdc_end_request() Tejun Heo
2009-04-23 13:33 ` David Miller
2009-04-28 2:54 ` Tejun Heo
2009-04-23 12:25 ` [PATCH 06/12] ubd: cleanup completion path Tejun Heo
2009-04-23 12:25 ` [PATCH 07/12] ubd: drop unnecessary rq->sector manipulation Tejun Heo
2009-04-23 12:25 ` [PATCH 08/12] hd: clean up request completion paths Tejun Heo
2009-04-23 12:25 ` [PATCH 09/12] swim3: " Tejun Heo
2009-04-23 12:25 ` [PATCH 10/12] swim: " Tejun Heo
2009-04-23 12:25 ` [PATCH 11/12] mg_disk: fold mg_disk.h into mg_disk.c Tejun Heo
2009-04-23 12:25 ` [PATCH 12/12] mg_disk: clean up request completion paths Tejun Heo
2009-04-24 19:41 ` [RFC PATCHSET linux-2.6-block#for-2.6.31] block: lld cleanup patches Bartlomiej Zolnierkiewicz
2009-04-28 3:44 ` Tejun Heo
2009-04-28 18:38 ` Bartlomiej Zolnierkiewicz
2009-04-28 22:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240489553-15724-5-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=Laurent@lvivier.info \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=donari75@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jdike@linux.intel.com \
--cc=joerg@dorchain.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox