RE: [PATCH 2/5] mm: remove unlikly NULL from kfree

Pekka Enberg
2009-03-25T08:06:55Z

On Wed, 2009-03-25 at 01:02 -0700, Hua Zhong wrote:
> > But those are _error handling paths_ (at least supposed to be). I
> > wonder which call-sites are responsible for this. Can frtrace help us
> > here?
>
> I am not sure why you call these error paths.
>
> I submitted the same patch two years ago, and you are still holding the same
> argument.
>
> http://www.archivum.info/linux.kernel/2006-04/msg06042.html
>
> Have you used likely profiler? These are real numbers. If you insist on
> calling them error paths then error paths are obviously the norm.

I am not denying the results, I am just saying that they don't make much
sense to me. Like I said, I would love to see the actual call-sites to
prove my argument wrong.

Pekka