Re: [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys

Daniel Walker
2009-04-27T16:41:24Z

On Wed, 2009-03-25 at 01:19 -0400, Steven Rostedt wrote:
> Ingo,
>
> I guess this can go through you. This is a start of clean ups to
> get rid of (un)likelys that are at least 50% incorrect. This series
> has some that are 100% incorrect.
>
> The branch profiler used is from 2.6.29 which does not have the
> fixed header that is in tip. This branch is also based off of
> 2.6.29 and not tip.
>
> Perhaps, since some of these cases are 100% wrong they can simply
> be reversed. I'm choosing to just remove the annotation, and then
> later I'll be using the full branch profiler to look for candidates
> for adding (un)likelys. That way each added annotation can be
> scrutinized individually.

What kind of methodology are you using to determine which to remove? It
looks like some you review the code, and other you just remove based on
it being %50 wrong or more.. I found workloads are especially important.
Where finding one that is %50 or %100 wrong does necessarily mean
anything..

Daniel