Re: [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys

Steven Rostedt
2009-03-25T13:44:00Z

On Wed, 25 Mar 2009, Ingo Molnar wrote:

>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > ----
> > arch/x86/kernel/ptrace.c | 4 ++--
> > kernel/sched.c | 4 ++--
> > kernel/sched_rt.c | 2 +-
> > mm/rmap.c | 8 ++++----
> > mm/slab.c | 2 +-
> > mm/slob.c | 2 +-
> > mm/slub.c | 2 +-
> > 7 files changed, 12 insertions(+), 12 deletions(-)
>
> I commented on the ptrace one - i think we should take that one out
> or at least wait for more info.
>
> The MM ones look correct. Maybe your kfree observation will be
> debated - but i think it's probably right that we should not special
> annotate kfree(NULL) anymore in any direction. But it's ultimately
> up to the MM folks. (I've Cc:-ed Pekka too)
>
> The rmap and the scheduler ones definitely look correct. When you
> rebase, please include the profiler output to 3/5 too.

I'll rebase it to only include the non controversial changes.

Thanks,

-- Steve