From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758490AbZD1EJ0 (ORCPT ); Tue, 28 Apr 2009 00:09:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751908AbZD1EHm (ORCPT ); Tue, 28 Apr 2009 00:07:42 -0400 Received: from hera.kernel.org ([140.211.167.34]:38774 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbZD1EHl (ORCPT ); Tue, 28 Apr 2009 00:07:41 -0400 From: Tejun Heo To: axboe@kernel.dk, linux-kernel@vger.kernel.org, donari75@gmail.com, bzolnier@gmail.com, joerg@dorchain.net, geert@linux-m68k.org, davem@davemloft.net, jdike@linux.intel.com, benh@kernel.crashing.org, Laurent@lvivier.info Cc: Tejun Heo Subject: [PATCH 02/14] block: don't init rq fields unnecessarily Date: Tue, 28 Apr 2009 13:06:05 +0900 Message-Id: <1240891577-4813-3-git-send-email-tj@kernel.org> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1240891577-4813-1-git-send-email-tj@kernel.org> References: <1240891577-4813-1-git-send-email-tj@kernel.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Tue, 28 Apr 2009 04:06:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org blk_get_request() always returns properly zeroed requests. Don't set fields to zero/NULL unnecessarily. [ Impact: cleanup ] Signed-off-by: Tejun Heo --- block/scsi_ioctl.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index bb9aa43..58cf456 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c @@ -500,8 +500,6 @@ static int __blk_send_generic(struct request_queue *q, struct gendisk *bd_disk, rq = blk_get_request(q, WRITE, __GFP_WAIT); rq->cmd_type = REQ_TYPE_BLOCK_PC; - rq->data_len = 0; - rq->extra_len = 0; rq->timeout = BLK_DEFAULT_SG_TIMEOUT; rq->cmd[0] = cmd; rq->cmd[4] = data; -- 1.6.0.2