Re: [PATCH 01/21] x86: add methods for writing of an MSR on several CPUs

H. Peter Anvin
2009-04-29T17:40:43Z

Borislav Petkov wrote:
> +}
> +
> +/* rdmsr on a bunch of cpus
> + *
> + * @mask: which cpus
> + * @msr_no: which MSR
> + * @l: array of the lower 32-bit MSR values
> + * @h: array of the higher 32-bit MSR values
> + *

Urk!

Please, for the love of God, no!

Make it an array of u64s or (equivalently!) an array of (l,h)
structures, not separate arrays for the halves of the register.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.