Re: [RFC PATCH 00/21 v2] amd64_edac: EDAC module for AMD64

Andi Kleen
2009-04-29T19:30:51Z

Borislav Petkov <borislav.petkov@amd.com> writes:

> Hi,
>
> thanks to all reviewers of the previous submission, here is the second
> version of this series.

The classic problem of the previous versions of these patches was that
they consume the same error registers (even if using pci config versus
msrs as access methods) as the kernel machine check poll/threshold
interrupt code. And with two logging agents racing on the same
registers you will always get junk results. Typically with threshold
enabled the mce code wins the race. I suspect this patchkit has
exactly the same fundamental design problem. EDAC really is not
particularly fitting for integrated memory controllers that report
their errors using standard machine check events.

-Andi (who thinks all of this decoding should be in user space anyways)

--
ak@linux.intel.com -- Speaking for myself only.