Re: [PATCH 13/21] amd64_edac: add f10-and-later methods-p3

Borislav Petkov
2009-04-30T10:01:25Z

Hi,

On Wed, Apr 29, 2009 at 10:47:30PM +0200, Ingo Molnar wrote:

[..]

> What i point out below is precisely what you say is ineligible
> under:
>
> > > Of course, we don't have to use StinkyIdentifiers anywhere else.
>
> I'd extend that rule to say that StinkyIdentifiers should only be
> used for hw API definitions/constants - macros, enums - not really
> local variable names. The moment they are allowed into local
> variables the stuff below happens.

to agree with Andrew, at a certain point in time I thought that having
the same register bit names as in the docs would be preferential when
you look at the docs and what the code does. But Ingo's also quite
right: we can't have "normal kernel coding style" and StinkyIdentifiers
:) in the same source file.

/me locking himself back in the patch creation basement.

--
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632