Re: [PATCH 12/21] amd64_edac: add f10-and-later methods-p2

Mauro Carvalho Chehab
2009-05-04T23:26:54Z

Borislav Petkov escreveu:
> +/*
> + * f10_lookup_addr_in_dct
> + *
> + * Iterate over the DRAM DCT "base" and "mask" register looking for
> + * a SystemAddr match on the specified 'ChannelSelect' and 'NodeID'
> + *
> + * Return:
> + * -1 NOT FOUND
> + * 0..csrow = Chip-Select Row
> + */
> +static int f10_lookup_addr_in_dct(u32 InputAddr, u32 NodeID, u32 ChannelSelect)
> +{
> + struct mem_ctl_info *mci;
> + struct amd64_pvt *pvt;
> + u32 CSBase, CSMask;
> + int CSFound = -1;
> + int csrow;
> +
> + mci = mci_lookup[NodeID];
> + if (!mci)
> + return CSFound;
>

It is better to use a standard error code like -EINVAL instead of using
-1 for error.

Cheers,
Mauro.