public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: Greg KH <greg@kroah.com>
Cc: Valdis.Kletnieks@vt.edu, Mike Frysinger <vapier.adi@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: usbutils 0.81 release
Date: Thu, 30 Apr 2009 03:48:41 +0200	[thread overview]
Message-ID: <1241056121.18530.31.camel@poy> (raw)
In-Reply-To: <20090429215623.GA27319@kroah.com>

On Wed, 2009-04-29 at 14:56 -0700, Greg KH wrote:

> If youreally want it, you can grab it from the git tree, or wait a day
> or so for me to implement Mike's changes he so nicely sent me, so I can
> do a new release.

How about this? It substitutes the script and the man page with the
given --datadir=.

Git is here:
  git://git.kernel.org/pub/scm/linux/kernel/git/kay/usbutils.git

It installs the update script, which will overwrite the original
location, so we don't need to put several files on the system, and avoid
confusing other packages who look for them.

The right fix for the users of the ids file would probably be to drop a
usbutils pkg-config file which can point users to the location of the
database, so other packages could use that value without starting to
search for the file.

We already need do this silly search in the udev-extras build, and there
seems not two known distros, who share the same location of that
file. :(

Thanks,
Kay


diff --git a/.gitignore b/.gitignore
index fc743f1..cc378da 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,4 +15,5 @@ depcomp
 install-sh
 missing
 lsusb
-
+lsusb.8
+update-usbids.sh
diff --git a/Makefile.am b/Makefile.am
index 7c20acb..a88c3b4 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -10,6 +10,9 @@ endif
 sbin_PROGRAMS = \
 	lsusb
 
+sbin_SCRIPTS = \
+	update-usbids.sh
+
 lsusb_SOURCES = \
 	lsusb.c \
 	lsusb-t.c \
@@ -25,17 +28,28 @@ lsusb_CPPFLAGS = \
 lsusb_LDADD = \
 	$(LIBUSB_LIBS)
 
-dist_man_MANS = \
+man_MANS = \
 	lsusb.8
 
 EXTRA_DIST = \
-	usb.ids
+	usb.ids \
+	update-usbids.sh.in \
+	lsusb.8.in
+
+update-usbids.sh: update-usbids.sh.in
+	sed 's|@usbids@|$(datadir)/usb.ids|' $< >$@
+	chmod 755 $@
+
+lsusb.8: lsusb.8.in
+	sed 's|@usbids@|$(datadir)/usb.ids|' $< >$@
 
 usb.ids.gz: usb.ids
 	gzip -c -9 usb.ids > usb.ids.gz
 
 clean-local:
 	rm -f usb.ids.gz
+	rm -f lsusb.8
+	rm -f update-usbids.sh
 
 distclean-local:
 	rm -rf autom4te.cache
diff --git a/configure.ac b/configure.ac
index 9bf677c..8b6bd2f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -39,6 +39,7 @@ echo "
 	=============
 
 	prefix:                 ${prefix}
+	datadir:                ${datadir}
 	datarootdir:            ${datarootdir}
 	mandir:                 ${mandir}
 
diff --git a/lsusb.8 b/lsusb.8.in
similarity index 98%
rename from lsusb.8
rename to lsusb.8.in
index 14e662c..1922b0a 100644
--- a/lsusb.8
+++ b/lsusb.8.in
@@ -55,7 +55,7 @@ If the specified device is not found, a non-zero exit code is returned.
 
 .SH FILES
 .TP
-.B /usr/share/usb.ids
+.B @usbids@
 A list of all known USB ID's (vendors, products, classes, subclasses and protocols).
 
 .SH SEE ALSO
diff --git a/update-usbids.sh b/update-usbids.sh.in
similarity index 98%
rename from update-usbids.sh
rename to update-usbids.sh.in
index 3072f03..4a487ed 100755
--- a/update-usbids.sh
+++ b/update-usbids.sh.in
@@ -6,7 +6,7 @@
 
 set -e
 SRC="http://www.linux-usb.org/usb.ids"
-DEST=usb.ids
+DEST=@usbids@
 
 # if usb.ids is read-only (because the filesystem is read-only),
 # then just skip this whole process.


  parent reply	other threads:[~2009-04-30  1:49 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 19:35 usbutils 0.81 release Greg KH
2009-04-27 20:48 ` Alan Stern
2009-04-27 21:00   ` Greg KH
2009-04-27 21:21     ` Alan Stern
2009-04-27 21:36       ` Kay Sievers
2009-04-29 14:23       ` Benny Amorsen
2009-04-29 15:51         ` Alan Stern
2009-04-29 17:27           ` Mike Frysinger
2009-04-29 17:42           ` Greg KH
2009-04-29 20:23             ` Alan Stern
2009-04-27 21:07   ` Kay Sievers
2009-04-27 21:54     ` Alan Stern
2009-04-27 22:02       ` Kay Sievers
2009-04-29 17:53 ` Mike Frysinger
2009-04-29 18:07   ` Greg KH
2009-04-29 18:17     ` Mike Frysinger
2009-04-29 18:30       ` Greg KH
2009-04-29 23:38         ` Mike Frysinger
2009-04-30  0:45           ` Kay Sievers
2009-04-30  1:48             ` Mike Frysinger
2009-04-30  1:54               ` Kay Sievers
2009-04-30  1:58                 ` Mike Frysinger
2009-04-29 18:59       ` Kay Sievers
2009-04-29 19:18         ` Henrique de Moraes Holschuh
2009-04-29 19:26           ` Greg KH
2009-04-29 19:44             ` Kay Sievers
2009-04-29 19:27           ` Kay Sievers
2009-04-29 19:50             ` Henrique de Moraes Holschuh
2009-04-29 19:55               ` Kay Sievers
2009-04-29 20:00                 ` Henrique de Moraes Holschuh
2009-04-29 20:39                   ` Kay Sievers
2009-04-30  6:31           ` Bjørn Mork
2009-04-29 19:23         ` Greg KH
2009-04-29 21:42           ` Valdis.Kletnieks
2009-04-29 21:56             ` Greg KH
2009-04-29 22:19               ` Valdis.Kletnieks
2009-04-30  1:48               ` Kay Sievers [this message]
2009-04-30  1:56                 ` Mike Frysinger
2009-04-30  2:06                   ` Kay Sievers
2009-04-30  2:13                     ` Mike Frysinger
2009-04-30  4:54                       ` Greg KH
2009-04-29 21:57             ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241056121.18530.31.camel@poy \
    --to=kay.sievers@vrfy.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox