Re: [PATCH 08/10] block: cleanup rq->data_len usages

Tejun Heo
2009-05-04T04:31:23Z

Hello,

Boaz Harrosh wrote:
> OK, NP. But in this case please note on the side all the places you
> think might be suspect for blk_rq_bytes()/blk_rq_sectors()
> cosolidation and post the list. Because it is now that you are going
> over the code and it is now that you touch exactly all these places.
>
> You could even put a "TODO:" comments on all these places in this
> patch. So to draw later patches that audit and remove the TODO:.

Heh... okay. I'll add a patch for the sweep conversion.

> (Or in trivial places like above that are safe even before these
> patches, just convert them silently, in the sense of least traffic)

I really don't want to do that. Things which might look trivial often
break things and this part of API has been quite fragile, so I'd
rather put those changes after the actual unification for, if nothing
else, documentation.

> But sure I will see what I can help and send patches for. Tell me
> when you think this is stable enough for me to add patches on top
> of.

Yeap, I just finished saving the wasteland, so the refreshed patchset
will be posted later today. :-)

Thanks.

--
tejun