From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762891AbZD3V77 (ORCPT ); Thu, 30 Apr 2009 17:59:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755533AbZD3V7u (ORCPT ); Thu, 30 Apr 2009 17:59:50 -0400 Received: from gate.crashing.org ([63.228.1.57]:40403 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754688AbZD3V7u (ORCPT ); Thu, 30 Apr 2009 17:59:50 -0400 Subject: Re: [BUG] 2.6.30-rc3: BUG triggered on some hugepage usages From: Benjamin Herrenschmidt To: Mel Gorman Cc: Michael Ellerman , Linus Torvalds , linuxppc-dev@ozlabs.org, Linux Kernel Mailing List In-Reply-To: <20090430205919.GA24279@csn.ul.ie> References: <20090424095116.GB14283@csn.ul.ie> <1240586690.12551.31.camel@localhost> <20090430205919.GA24279@csn.ul.ie> Content-Type: text/plain Date: Fri, 01 May 2009 07:48:46 +1000 Message-Id: <1241128126.29501.48.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2009-04-30 at 21:59 +0100, Mel Gorman wrote: > This patch fixes the problem by not asseting the PTE is locked for VMAs > backed by huge pages. Thanks, will apply. Cheers, Ben. > Signed-off-by: Mel Gorman > --- > arch/powerpc/mm/pgtable.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index f5c6fd4..ae1d67c 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -219,7 +219,8 @@ int ptep_set_access_flags(struct vm_area_struct *vma, unsigned long address, > entry = do_dcache_icache_coherency(entry); > changed = !pte_same(*(ptep), entry); > if (changed) { > - assert_pte_locked(vma->vm_mm, address); > + if (!(vma->vm_flags & VM_HUGETLB)) > + assert_pte_locked(vma->vm_mm, address); > __ptep_set_access_flags(ptep, entry); > flush_tlb_page_nohash(vma, address); > }