Re: [PATCH 03/11] block: add rq->resid_len

Tejun Heo
2009-05-05T03:43:30Z

Sergei Shtylyov wrote:
>> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
>> index 7149224..3813a0e 100644
>> --- a/drivers/ide/ide-tape.c
>> +++ b/drivers/ide/ide-tape.c
>> @@ -380,7 +380,7 @@ static int ide_tape_callback(ide_drive_t *drive,
>> int dsc)
>> }
>>
>> tape->first_frame += blocks;
>> - rq->data_len -= blocks * tape->blk_size;
>> + rq->resid_len = blk_rq_bytes(rq) - blocks * tape->blk_size;
>
> Is it already guaranteed that rq->data_len == blk_rq_bytes(rq) here?

Oops, no. I'll move it to later ide-cleanup-rq-data_len-usages patch.

Thanks.

--
tejun