public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Arve Hjønnevåg" <arve@android.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@suse.de, rientjes@google.com, akpm@linux-foundation.org,
	npiggin@suse.de, san@android.com,
	"Arve Hjønnevåg" <arve@android.com>
Subject: [PATCH 2/2] lowmemorykiller: Don't count free space unless it meets the specified limit by itself
Date: Mon,  4 May 2009 15:24:49 -0700	[thread overview]
Message-ID: <1241475889-2281-2-git-send-email-arve@android.com> (raw)
In-Reply-To: <1241475889-2281-1-git-send-email-arve@android.com>

This allows processes to be killed when the kernel evict cache pages in
an attempt to get more contiguous free memory.

Signed-off-by: Arve Hjønnevåg <arve@android.com>
---
 drivers/staging/android/lowmemorykiller.c |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index b9a2e84..b2ab7fa 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -58,20 +58,25 @@ static int lowmem_shrink(int nr_to_scan, gfp_t gfp_mask)
 	int min_adj = OOM_ADJUST_MAX + 1;
 	int selected_tasksize = 0;
 	int array_size = ARRAY_SIZE(lowmem_adj);
-	int other_free = global_page_state(NR_FREE_PAGES) + global_page_state(NR_FILE_PAGES);
+	int other_free = global_page_state(NR_FREE_PAGES);
+	int other_file = global_page_state(NR_FILE_PAGES);
 	if(lowmem_adj_size < array_size)
 		array_size = lowmem_adj_size;
 	if(lowmem_minfree_size < array_size)
 		array_size = lowmem_minfree_size;
 	for(i = 0; i < array_size; i++) {
-		if(other_free < lowmem_minfree[i]) {
+		if (other_free < lowmem_minfree[i] &&
+		    other_file < lowmem_minfree[i]) {
 			min_adj = lowmem_adj[i];
 			break;
 		}
 	}
 	if(nr_to_scan > 0)
-		lowmem_print(3, "lowmem_shrink %d, %x, ofree %d, ma %d\n", nr_to_scan, gfp_mask, other_free, min_adj);
-	rem = global_page_state(NR_ACTIVE) + global_page_state(NR_INACTIVE);
+		lowmem_print(3, "lowmem_shrink %d, %x, ofree %d %d, ma %d\n", nr_to_scan, gfp_mask, other_free, other_file, min_adj);
+	rem = global_page_state(NR_ACTIVE_ANON) +
+		global_page_state(NR_ACTIVE_FILE) +
+		global_page_state(NR_INACTIVE_ANON) +
+		global_page_state(NR_INACTIVE_FILE);
 	if (nr_to_scan <= 0 || min_adj == OOM_ADJUST_MAX + 1) {
 		lowmem_print(5, "lowmem_shrink %d, %x, return %d\n", nr_to_scan, gfp_mask, rem);
 		return rem;
-- 
1.6.1


  reply	other threads:[~2009-05-04 22:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 16:35 [patch 1/5] oom: cleanup android low memory killer David Rientjes
2009-05-04 16:35 ` [patch 2/5] oom: fix possible android low memory killer NULL pointer David Rientjes
2009-05-04 16:35 ` [patch 3/5] oom: fix possible oom_dump_tasks " David Rientjes
2009-05-04 16:35 ` [patch 4/5] oom: move oom_adj value from task_struct to mm_struct David Rientjes
2009-05-04 16:35 ` [patch 5/5] oom: prevent possible OOM_DISABLE livelock David Rientjes
2009-05-04 21:48 ` [patch 1/5] oom: cleanup android low memory killer Arve Hjønnevåg
2009-05-04 22:09   ` Greg KH
2009-05-04 22:24     ` [PATCH 1/2] lowmemorykiller: Only iterate over process list when needed Arve Hjønnevåg
2009-05-04 22:24       ` Arve Hjønnevåg [this message]
2009-05-04 22:35     ` [patch 1/5] oom: cleanup android low memory killer David Rientjes
2009-05-04 22:59       ` Greg KH
2009-05-04 23:12         ` David Rientjes
2009-05-04 23:16           ` Greg KH
2009-05-04 23:36             ` Arve Hjønnevåg
2009-05-04 23:59             ` David Rientjes
2009-05-04 23:32           ` Rik van Riel
2009-05-11 19:44             ` David Rientjes
2009-05-14 12:23               ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241475889-2281-2-git-send-email-arve@android.com \
    --to=arve@android.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=rientjes@google.com \
    --cc=san@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox