Re: [PATCH 11/18] swim: dequeue in-flight request

Tejun Heo
2009-05-16T14:39:33Z

Sergei Shtylyov wrote:
> And without duplication:

Similar response as the if/else one on the other thread. Is it really
any significantly better? The 'duplication' here is basically one
liner after the peek/fetch change and when the duplication is minimal,
I usually find it clearer to put the loop condition at the while
clause itself. If you think it's significantly better, please go
ahead and submit the patch but to me the change you're proposing is
basically cosmetic and not even a clearly better one at that.

Thanks.

--
tejun