From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
cl@linux.com, mingo@elte.hu, mel@csn.ul.ie,
linux-kernel@vger.kernel.org, riel@redhat.com,
rientjes@google.com, xemul@openvz.org
Subject: Re: [RFC/PATCH v2] mm: Introduce GFP_PANIC for non-failing allocations
Date: Fri, 08 May 2009 16:50:07 +0300 [thread overview]
Message-ID: <1241790607.28600.36.camel@penberg-laptop> (raw)
In-Reply-To: <20090508133704.GE6132@lenovo>
On Fri, 2009-05-08 at 17:37 +0400, Cyrill Gorcunov wrote:
> Thanks Pekka! At moment it's usefull for x86 uv_system_init (3 times)
> for early boot code. Plain panic_on_null (suggested by Andrew) could
> be usefull as well but would lead to additional wrapper around kmalloc
> which is already inlined. Which means -- at moment we have those cases
> handled by BUG_ON but having one common option would be better I guess
> (ie have an ability to say page allocator that just do panic on fail).
>
> Anyway, if there is still objections on such an approach (even having
> gpf bits saved by elegant way Pekka suggested) -- I'm fine with having
> those BUG_ONs instead of short and gracious GFP_PANIC :)
There are such BUG_ONs in SLUB, for example, and probably elsewhere in
early-boot code.
Pekka
next prev parent reply other threads:[~2009-05-08 13:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 12:27 [PATCH -tip] mm: introduce __GFP_PANIC modifier Cyrill Gorcunov
2009-05-04 13:13 ` Ingo Molnar
2009-05-04 13:16 ` Cyrill Gorcunov
2009-05-04 13:47 ` Christoph Lameter
2009-05-04 14:12 ` Cyrill Gorcunov
2009-05-04 14:13 ` Christoph Lameter
2009-05-04 14:29 ` Cyrill Gorcunov
2009-05-04 15:20 ` Cyrill Gorcunov
2009-05-04 15:54 ` Christoph Lameter
2009-05-04 16:11 ` Cyrill Gorcunov
2009-05-04 19:11 ` Cyrill Gorcunov
2009-05-04 18:53 ` Andrew Morton
2009-05-04 19:21 ` Cyrill Gorcunov
2009-05-04 19:34 ` Andrew Morton
2009-05-04 20:09 ` Cyrill Gorcunov
2009-05-08 12:57 ` [RFC/PATCH v2] mm: Introduce GFP_PANIC for non-failing allocations Pekka Enberg
2009-05-08 13:37 ` Cyrill Gorcunov
2009-05-08 13:50 ` Pekka Enberg [this message]
2009-05-08 14:17 ` Christoph Lameter
2009-05-08 14:20 ` Christoph Lameter
2009-05-08 14:23 ` Pekka Enberg
2009-05-08 14:29 ` Christoph Lameter
2009-05-08 14:34 ` Pekka Enberg
2009-05-08 14:37 ` Rik van Riel
2009-05-08 14:39 ` Pekka Enberg
2009-05-08 14:43 ` Christoph Lameter
2009-05-04 19:23 ` [PATCH -tip] mm: introduce __GFP_PANIC modifier Mel Gorman
2009-05-04 19:35 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241790607.28600.36.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox