Re: [RFC PATCH 0/12] ide-atapi remove pc->buf

Bartlomiej Zolnierkiewicz
2009-05-10T21:37:44Z

Hi,

On Saturday 09 May 2009 09:45:20 Borislav Petkov wrote:
> Hi Bart,
>
> Here's an assortment :) of ide patches touching stuff here and there.
> I've been working on those for a while and initial testing shows no
> problems. Among the changes is a first attempt to remove the 64 byte
> buffer embedded in each packet command sent to an ide drive. Also, some
> ireason handling unification is there along with other minor stuff.

Generally looks good but needs some fixes (see my other mails).

[ also: if you are re-posting any patches please always indicate whether
(and how) they were changed ]

> This is based ontop of
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-unify-sector-and-data_len
>
> and I'm more than open to suggestions on the logistics of merging those
> (how/when/on top of whose branch/who picks them up/do we want to hit the
> .31 merge window or do more testing?/etc) after being reviewed.
>
>
> drivers/ide/ide-atapi.c | 145 +++++++++++++++++++++++------------
> drivers/ide/ide-cd.c | 69 +++--------------
> drivers/ide/ide-floppy.c | 53 ++++++-------
> drivers/ide/ide-floppy_ioctl.c | 43 ++++++-----
> drivers/ide/ide-tape.c | 168 +++++++++++++++++++---------------------
> include/linux/ide.h | 18 +----
> 6 files changed, 238 insertions(+), 258 deletions(-)

Good question, how's about:

Once tj/block-unify-sector-and-data_len is in block/for-2.6.31 and your tree
is ready I will pull it into the separate branch. This branch can be then
pulled into ide/for-next or into new ide/all branch (replacing ide/for-next
in linux-next).

This means that I'll have to synchronize merge window merges with Jens but
this is needed already and shouldn't be a problem.

If somebody [ Tejun/Jens: I'm talking to you :) ] has a better idea how to
handle this please stand-up.

Thanks,
Bart