public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@kernel.org>,
	Robert Richter <robert.richter@amd.com>,
	x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 14/15 -tip] x86: Add cpufeature for performance frequency APERF/MPERF
Date: Mon, 11 May 2009 22:25:05 +0530	[thread overview]
Message-ID: <1242060905.5139.24.camel@ht.satnam> (raw)
In-Reply-To: <1242060858.5139.23.camel@ht.satnam>


X86_FEATURE_PERF_FREQ : Hardware Coordination Feedback Capability
                        (Presence of IA32_APERF, IA32_MPERF MSRs)

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
 arch/x86/include/asm/cpufeature.h          |    1 +
 arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c |    9 ++-------
 arch/x86/kernel/cpu/intel.c                |    9 +++++++++
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
index aee0978..b91cb47 100644
--- a/arch/x86/include/asm/cpufeature.h
+++ b/arch/x86/include/asm/cpufeature.h
@@ -168,6 +168,7 @@
 #define X86_FEATURE_SMM 	(7*32+ 13) /* System Management	Mode	*/
 #define X86_FEATURE_MM_CFG 	(7*32+ 14) /* MM configuration		*/
 #define X86_FEATURE_BUS_CFG 	(7*32+ 15) /* Bus configuration		*/
+#define X86_FEATURE_PERF_FREQ 	(7*32+ 16) /* Performance frequency	*/
 
 /* Virtualization flags: Linux defined */
 #define X86_FEATURE_TPR_SHADOW  (8*32+ 0) /* Intel TPR Shadow */
diff --git a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
index 208ecf6..3811ca6 100644
--- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
+++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
@@ -60,7 +60,6 @@ enum {
 };
 
 #define INTEL_MSR_RANGE		(0xffff)
-#define CPUID_6_ECX_APERFMPERF_CAPABILITY	(0x1)
 
 struct acpi_cpufreq_data {
 	struct acpi_processor_performance *acpi_data;
@@ -735,12 +734,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	acpi_processor_notify_smm(THIS_MODULE);
 
 	/* Check for APERF/MPERF support in hardware */
-	if (c->x86_vendor == X86_VENDOR_INTEL && c->cpuid_level >= 6) {
-		unsigned int ecx;
-		ecx = cpuid_ecx(6);
-		if (ecx & CPUID_6_ECX_APERFMPERF_CAPABILITY)
-			acpi_cpufreq_driver.getavg = get_measured_perf;
-	}
+	if (cpu_has(c, X86_FEATURE_PERF_FREQ))
+		acpi_cpufreq_driver.getavg = get_measured_perf;
 
 	dprintk("CPU%u - ACPI performance management activated.\n", cpu);
 	for (i = 0; i < perf->state_count; i++)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 9c8f386..9c5169c 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -469,6 +469,15 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
 			break;
 		}
 	}
+	if (c->cpuid_level >= 6) {
+		/*
+		 * Hardware Coordination Feedback Capability
+		 * (Presence of IA32_APERF, IA32_MPERF MSRs)
+		 */
+		l2 = cpuid_ecx(6);
+		if (l2 & 1)
+			set_cpu_cap(c, X86_FEATURE_PERF_FREQ);
+	}
 }
 
 #ifdef CONFIG_X86_32
-- 
1.6.0.6




  reply	other threads:[~2009-05-11 17:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 16:14 [git-pull -tip] x86: Addition of cpufeatures to friendly access miscellaneous MSRs Jaswinder Singh Rajput
2009-05-11 16:29 ` Robert Richter
2009-05-11 16:41 ` [PATCH 1/15 -tip] x86: Add cpufeature for Processor Name Jaswinder Singh Rajput
2009-05-11 16:43   ` [PATCH 2/15 -tip] x86: Add cpufeatures for Advanced Power Management Jaswinder Singh Rajput
2009-05-11 16:44     ` [PATCH 3/15 -tip] x86: Add cpufeature for Microcode update Jaswinder Singh Rajput
2009-05-11 16:45       ` [PATCH 4/15 -tip] x86: Add cpufeature for Cache MSRs Jaswinder Singh Rajput
2009-05-11 16:48         ` [PATCH 5/15 -tip] x86: Add cpufeature for Hard and Soft Poweron configuration Jaswinder Singh Rajput
2009-05-11 16:49           ` [PATCH 6/15 -tip] x86: Add cpufeature for Scaleable bus speed Jaswinder Singh Rajput
2009-05-11 16:50             ` [PATCH 7/15 -tip] x86: Add cpufeature for Miscellaneous Features Jaswinder Singh Rajput
2009-05-11 16:50               ` [PATCH 8/15 -tip] x86: Add cpufeature for Platform feature Jaswinder Singh Rajput
2009-05-11 16:51                 ` [PATCH 9/15 -tip] x86: Add cpufeature for Hardware configuration Jaswinder Singh Rajput
2009-05-11 16:52                   ` [PATCH 10/15 -tip] x86: Add cpufeature for System configuration Jaswinder Singh Rajput
2009-05-11 16:52                     ` [PATCH 11/15 -tip] x86: Add cpufeature for System management mode (SMM) Jaswinder Singh Rajput
2009-05-11 16:53                       ` [PATCH 12/15 -tip] x86: Add cpufeature for MM configuration Jaswinder Singh Rajput
2009-05-11 16:54                         ` [PATCH 13/15 -tip] x86: Add cpufeature for Bus configuration Jaswinder Singh Rajput
2009-05-11 16:55                           ` Jaswinder Singh Rajput [this message]
2009-05-11 16:55                             ` [PATCH 15/15 -tip] x86: Add cpufeature for ancient performance monitoring Jaswinder Singh Rajput
2009-05-11 18:13     ` [PATCH 2/15 -tip] x86: Add cpufeatures for Advanced Power Management H. Peter Anvin
2009-05-11 19:09       ` Ingo Molnar
2009-05-12  0:31         ` Jaswinder Singh Rajput
2009-05-11 18:15 ` [git-pull -tip] x86: Addition of cpufeatures to friendly access miscellaneous MSRs H. Peter Anvin
2009-05-11 18:47   ` Robert Richter
2009-05-11 19:26     ` H. Peter Anvin
2009-05-12  0:42   ` Jaswinder Singh Rajput
2009-05-12  0:49     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242060905.5139.24.camel@ht.satnam \
    --to=jaswinder@kernel.org \
    --cc=hpa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=robert.richter@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox