Re: [PATCH 2/15 -tip] x86: Add cpufeatures for Advanced Power Management

[Jaswinder Singh Rajput <jaswinder@kernel.org>]

On Mon, 2009-05-11 at 21:09 +0200, Ingo Molnar wrote:
> * H. Peter Anvin <hpa@zytor.com> wrote:
> 
> > Jaswinder Singh Rajput wrote:
> >> 1. Add Advanced Power Management (Function 8000_0007h), edx
> >> 2. unification of X86_FEATURE_CONSTANT_TSC (from intel.c, amd.c to common.c)
> >> 3. Remove cpu/powerflags.c
> >> 4. Remove x86_power
> >> 5. Move 'power management' to flags of /proc/cpuinfo
> >>
> >> /proc/cpuinfo (before)
> >> flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
> >> mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt
> >> rdtscp lm 3dnowext 3dnow constant_tsc rep_good nonstop_tsc pni cx16
> >> lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch osvw skinit pname
> >> ..
> >> power management: ts ttp tm stc 100mhzsteps hwpstate
> >>
> >> /proc/cpuinfo (after)
> >> flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
> >> mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt
> >> rdtscp lm 3dnowext 3dnow rep_good tsc_reliable nonstop_tsc pni cx16
> >> lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch osvw skinit pname
> >> ts ttp htc stc 100mhzsteps hwpstate constant_tsc
> >>
> >> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> >
> > NAK in the extreme.
> >
> > This is an incompatible change to a userspace visible API.  The 
> > fact that power management flags were separate was braindamage in 
> > the first place, of course, but we don't break established 
> > userspace APIs even if they're stupid.
> 
> Yes, and you pointed it out in an earlier reply.
> 
> Jaswinder, as hpa said it before, we only ever extend cpuflags (i.e. 
> add new ones mainly, and map new CPUs to the existing flags), but we 
> dont change their semantics.
> 

OK, then I will remove from this patch :

 3. Remove cpu/powerflags.c
 4. Remove x86_power
 5. Move 'power management' to flags of /proc/cpuinfo

--
JSR