From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbbDCT3u (ORCPT ); Fri, 3 Apr 2015 15:29:50 -0400 Received: from mail.eperm.de ([89.247.134.16]:58128 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbbDCT3r (ORCPT ); Fri, 3 Apr 2015 15:29:47 -0400 From: Stephan Mueller To: Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] crypto: remove instance when test failed Date: Fri, 03 Apr 2015 21:29:44 +0200 Message-ID: <12421064.DcDv9fIrjP@tachyon.chronox.de> User-Agent: KMail/4.14.6 (Linux/3.19.3-200.fc21.x86_64; KDE/4.14.6; x86_64; ; ) In-Reply-To: <20150403155246.GA21458@gondor.apana.org.au> References: <3394653.LODBE1uz62@tachyon.chronox.de> <1731327.mgbsjj4MeV@tachyon.chronox.de> <20150403155246.GA21458@gondor.apana.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 3. April 2015, 23:52:46 schrieb Herbert Xu: Hi Herbert, > On Fri, Apr 03, 2015 at 05:17:13PM +0200, Stephan Mueller wrote: > > Wpuldn't crypto_del_alg suffer from the same issue? I see that the > > cra_refcnt is checked. But I guess there would be the same kind of race? > > You're quite right. It too needs to take a ref count on the > algorithm in crypto_alg_match before releasing the mutex. > What about moving the current crypto_unregister_instance into __crypto_unregister_instance and creating a new crypto_unregister_instance that takes the ref count and once it got it, it calls __crypto_unregister_instance. If it did not get the ref count, it simply returns because the inst apparently was already removed. Only the crypto_unregister_instance is EXPORT_SYMBOL whereas the __crypto_unregister_instance is static. > Cheers, -- Ciao Stephan