From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/3] perf_counter: powerpc: supply more precise information on counter overflow events
Date: Thu, 14 May 2009 08:51:32 +0200 [thread overview]
Message-ID: <1242283892.26820.43.camel@twins> (raw)
In-Reply-To: <18955.37028.48861.555309@drongo.ozlabs.ibm.com>
On Thu, 2009-05-14 at 13:31 +1000, Paul Mackerras wrote:
> This uses values from the MMCRA, SIAR and SDAR registers on powerpc to
> supply more precise information for overflow events, including a data
> address when PERF_RECORD_ADDR is specified.
>
> Since POWER6 uses different bit positions in MMCRA from earlier processors,
> this converts the struct power_pmu limited_pmc5_6 field, which only had
> 0/1 values, into a flags field and defines bit values for its previous
> use (PPMU_LIMITED_PMC5_6) and a new flag (PPMU_ALT_SIPR) to indicate
> that the processor uses the POWER6 bit positions rather than the earlier
> positions. It also adds definitions in reg.h for the new and old positions
> of the bit that indicates that the SIAR and SDAR values come from the
> same instruction.
>
> For the data address, the SDAR value is supplied if we are not doing
> instruction sampling. In that case there is no guarantee that the address
> given in the PERF_RECORD_ADDR subrecord will correspond to the instruction
> whose address is given in the PERF_RECORD_IP subrecord.
>
> If instruction sampling is enabled (e.g. because this counter is counting
> a marked instruction event), then we only supply the SDAR value for the
> PERF_RECORD_ADDR subrecord if it corresponds to the instruction whose
> address is in the PERF_RECORD_IP subrecord. Otherwise we supply 0.
Very cool hardware feature! :-)
next prev parent reply other threads:[~2009-05-14 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 3:31 [PATCH 3/3] perf_counter: powerpc: supply more precise information on counter overflow events Paul Mackerras
2009-05-14 6:51 ` Peter Zijlstra [this message]
2009-05-15 14:44 ` [tip:perfcounters/core] " tip-bot for Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242283892.26820.43.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox