From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/3] perf_counter: allow arch to supply event misc flags and instruction pointer
Date: Thu, 14 May 2009 11:51:04 +0200 [thread overview]
Message-ID: <1242294664.6642.1000.camel@laptop> (raw)
In-Reply-To: <18955.59546.713452.302649@cargo.ozlabs.ibm.com>
On Thu, 2009-05-14 at 19:47 +1000, Paul Mackerras wrote:
> Peter Zijlstra writes:
>
> > On Thu, 2009-05-14 at 13:29 +1000, Paul Mackerras wrote:
>
> > > #define PERF_EVENT_MISC_KERNEL (1 << 0)
> > > #define PERF_EVENT_MISC_USER (1 << 1)
> > > #define PERF_EVENT_MISC_OVERFLOW (1 << 2)
> > > +#define PERF_EVENT_MISC_HYPERVISOR (1 << 3)
> >
> > Ah, I think I've taught userspace that either !USER && !KERNEL or USER
> > && KERNEL is HV information, since neither really makes sense :-)
>
> OK, should we do something like this?
>
> #define PERF_EVENT_MISC_CPUMODE_MASK (3 << 0)
> #define PERF_EVENT_MISC_CPUMODE_UNKNOWN (0 << 0)
> #define PERF_EVENT_MISC_USER (1 << 0)
> #define PERF_EVENT_MISC_KERNEL (2 << 0)
> #define PERF_EVENT_MISC_HYPERVISOR (3 << 0)
Yep, that reads nicer :-)
prev parent reply other threads:[~2009-05-14 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 3:29 [PATCH 2/3] perf_counter: allow arch to supply event misc flags and instruction pointer Paul Mackerras
2009-05-14 6:45 ` Peter Zijlstra
2009-05-14 9:47 ` Paul Mackerras
2009-05-14 9:51 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242294664.6642.1000.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox