Re: [PATCH 0/15 v2] ide-atapi: remove pc->buf and misc cleanups

Borislav Petkov
2009-05-17T10:33:58Z

Hi,

On Sat, May 16, 2009 at 09:35:52PM +0200, Bartlomiej Zolnierkiewicz wrote:

[..]

> > > Looking at creation dates I suspect that somewhere along the way
> > > something was rebased?
> > >
> > > One quick temporary solution would be to recreate bp/pc-remove-buf
> > > on top of tj/block-peek-fetch...
> >
> > will do that first thing in the morning and push it for merging.
>
> Cool, please also merge ide-tape DEBUG build fix while at it...

I'd suggest we merge that one before 2.6.30 hits the stores :) since it
is trivial enough and I won't have to backport it. Here's a rediffed
version against your for-next branch:

--

From: Mark de Wever <koraq@xs4all.nl>
Date: Sun, 17 May 2009 12:29:28 +0200
Subject: [PATCH] ide-tape: fix debug call

This error only occurs when IDETAPE_DEBUG_LOG is enabled.

Signed-off-by: Mark de Wever <koraq@xs4all.nl>
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
drivers/ide/ide-tape.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 8dfc688..203bbea 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -617,7 +617,7 @@ static ide_startstop_t idetape_do_request(ide_drive_t *drive,
struct ide_cmd cmd;
u8 stat;

- debug_log(DBG_SENSE, "sector: %llu, nr_sectors: %lu\n"
+ debug_log(DBG_SENSE, "sector: %llu, nr_sectors: %lu\n",
(unsigned long long)rq->sector, rq->nr_sectors);

if (!(blk_special_request(rq) || blk_sense_request(rq))) {
--
1.6.3

--
Regards/Gruss,
Boris.