Re: [PATCH 2/4] x86: simplify cpa_process_alias()

Tejun Heo
2009-05-14T15:36:37Z

Hello,

Jan Beulich wrote:
>>>> Tejun Heo <tj@kernel.org> 14.05.09 14:49 >>>
>> The two existing alias conditions in cpa_process_alias() are mutually
>> exclusive and future ones are likely to be exclusive too. Simplify
>> control flow to ease adding other alias cases.
>>
>> The within(vaddr, (unsigned long)_text, _brk_end) test is removed as
>> it's guaranteed to be false if vaddr is in the page mapped area.
>
> I don't think that's correct - just consider the case where the
> originally passed in virtual address is from the vmalloc area: In
> that case, both the 1:1 mapping *and* the kernel mapping need to be
> checked.

Yeap, you're right. I was reading the second condition in reversal.
Will update and repost. Thanks for spotting it.

--
tejun