public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Mario Limonciello <mario_limonciello@dell.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Explicitly disable BT radio using rfkill interface on suspend
Date: Mon, 18 May 2009 22:14:24 -0700	[thread overview]
Message-ID: <1242710064.3147.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20090519050327.GA22637@srcf.ucam.org>

Hi Matthew,

> > Dell BT adapters will startup in a HID mode.  In HID mode two logical
> > USB devices are exposed, a mouse and a keyboard.  If properly set, the
> > BT radio will work with pre-paired keyboards or mice in this mode.  This
> > is useful for things like BIOS control via a BT keyboard.  A command is
> > sent to one of the descriptors of the mouse to cause the device to
> > transition to HCI mode.  When transitioned to HCI mode, a radio device
> > is exposed allowing it to pair and operate with any BT device.
> > 
> > Here's what the utility looks like that ships with bluez:
> > http://git.kernel.org/?p=bluetooth/bluez.git;a=blob;f=tools/hid2hci.c;h=11d707fd76e940b884c9078907ab1504cd7350d4;hb=HEAD
> > Look at the switch_dell method to see how it works.
> > 
> > Currently, this is implemented via a set of udev rules shipped with
> > bluez that match the Dell device and transition it to HCI mode.
> > Here's the udev rule that matches:
> > ACTION=="add", ENV{ID_VENDOR}=="413c", ENV{ID_CLASS}=="mouse", ATTRS{bmAttributes}=="e0", KERNEL=="mouse*", RUN+="/usr/sbin/hid2hci --method dell -v $env{ID_VENDOR} -p $env{ID_MODEL} --mode hci"
> > 
> > When coming out of S3 if the killswitch isn't activated, the logical USB
> > mouse isn't coldplugged again preventing the udev rule from being
> > matched upon.  You can manually run hid2hci and the device will switch
> > modes.
> 
> Ok. I don't think the right way to implement this is forcing dell-laptop 
> to simulate an unplug. The HCI driver should be responsible for saving 
> and restoring state of the device in its suspend/resume method.

what do you expect the generic USB driver to do? I don't see anything we
can do about it, if the device gets removed from underneath us.

Regards

Marcel



  reply	other threads:[~2009-05-19  5:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 20:12 [PATCH] Explicitly disable BT radio using rfkill interface on suspend Mario Limonciello
2009-05-18 21:02 ` Matthew Garrett
2009-05-18 21:36   ` Mario Limonciello
2009-05-19  5:03     ` Matthew Garrett
2009-05-19  5:14       ` Marcel Holtmann [this message]
2009-05-19  6:27         ` Oliver Neukum
2009-05-19  6:45           ` Marcel Holtmann
2009-05-19  7:36             ` Oliver Neukum
2009-05-19  9:06         ` Matthew Garrett
2009-05-19 12:47           ` Oliver Neukum
2009-05-19 12:58             ` Matthew Garrett
2009-05-19 16:30               ` Mario Limonciello
2009-05-19 16:33                 ` Matthew Garrett
2009-05-19 16:52                   ` Mario Limonciello
2009-05-19 19:58                     ` Oliver Neukum
2009-05-19 20:36                       ` Mario Limonciello
2009-05-19 21:26                         ` Oliver Neukum
2009-05-19 21:47                           ` Mario Limonciello
2009-05-19 22:16                             ` Oliver Neukum
2009-05-19 22:19                               ` Mario Limonciello
2009-05-20  2:17                               ` Alan Stern
2009-05-20 12:29                                 ` Oliver Neukum
2009-05-20 14:17                                   ` Alan Stern
2009-05-20 17:52                                     ` Mario Limonciello
2009-05-20 18:31                                       ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242710064.3147.4.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox