From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755571AbZESFOp (ORCPT ); Tue, 19 May 2009 01:14:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753723AbZESFOi (ORCPT ); Tue, 19 May 2009 01:14:38 -0400 Received: from senator.holtmann.net ([87.106.208.187]:51106 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753479AbZESFOh (ORCPT ); Tue, 19 May 2009 01:14:37 -0400 Subject: Re: [PATCH] Explicitly disable BT radio using rfkill interface on suspend From: Marcel Holtmann To: Matthew Garrett Cc: Mario Limonciello , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20090519050327.GA22637@srcf.ucam.org> References: <4A11C126.1000704@dell.com> <20090518210241.GA17755@srcf.ucam.org> <4A11D4E8.1020807@dell.com> <20090519050327.GA22637@srcf.ucam.org> Content-Type: text/plain Date: Mon, 18 May 2009 22:14:24 -0700 Message-Id: <1242710064.3147.4.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthew, > > Dell BT adapters will startup in a HID mode. In HID mode two logical > > USB devices are exposed, a mouse and a keyboard. If properly set, the > > BT radio will work with pre-paired keyboards or mice in this mode. This > > is useful for things like BIOS control via a BT keyboard. A command is > > sent to one of the descriptors of the mouse to cause the device to > > transition to HCI mode. When transitioned to HCI mode, a radio device > > is exposed allowing it to pair and operate with any BT device. > > > > Here's what the utility looks like that ships with bluez: > > http://git.kernel.org/?p=bluetooth/bluez.git;a=blob;f=tools/hid2hci.c;h=11d707fd76e940b884c9078907ab1504cd7350d4;hb=HEAD > > Look at the switch_dell method to see how it works. > > > > Currently, this is implemented via a set of udev rules shipped with > > bluez that match the Dell device and transition it to HCI mode. > > Here's the udev rule that matches: > > ACTION=="add", ENV{ID_VENDOR}=="413c", ENV{ID_CLASS}=="mouse", ATTRS{bmAttributes}=="e0", KERNEL=="mouse*", RUN+="/usr/sbin/hid2hci --method dell -v $env{ID_VENDOR} -p $env{ID_MODEL} --mode hci" > > > > When coming out of S3 if the killswitch isn't activated, the logical USB > > mouse isn't coldplugged again preventing the udev rule from being > > matched upon. You can manually run hid2hci and the device will switch > > modes. > > Ok. I don't think the right way to implement this is forcing dell-laptop > to simulate an unplug. The HCI driver should be responsible for saving > and restoring state of the device in its suspend/resume method. what do you expect the generic USB driver to do? I don't see anything we can do about it, if the device gets removed from underneath us. Regards Marcel