From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] Documentation/connector/cn_test.c remove unused cn_test_want_notify()
Date: Wed, 20 May 2009 13:12:28 +0530 [thread overview]
Message-ID: <1242805348.3260.52.camel@localhost.localdomain> (raw)
In-Reply-To: <20090520072224.GA19823@ioremap.net>
On Wed, 2009-05-20 at 11:22 +0400, Evgeniy Polyakov wrote:
> On Wed, May 20, 2009 at 11:04:53AM +0530, Jaswinder Singh Rajput (jaswinder@kernel.org) wrote:
> >
> > Currently cn_test_want_notify() is not having any user.
>
> Do not remove it, disable with ifdef if you want, it is an example
> of how to get notifications about new connector user registration.
>
[PATCH -tip] Documentation/connector/cn_test.c comment unused cn_test_want_notify()
Currently cn_test_want_notify() is not having any user.
So adding ifdef and comment which tells to not remove it.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
Documentation/connector/cn_test.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Documentation/connector/cn_test.c b/Documentation/connector/cn_test.c
index 6977c17..f688eba 100644
--- a/Documentation/connector/cn_test.c
+++ b/Documentation/connector/cn_test.c
@@ -41,6 +41,12 @@ void cn_test_callback(void *data)
msg->seq, msg->ack, msg->len, (char *)msg->data);
}
+/*
+ * Do not remove this function even if no one is using it as
+ * this is an example of how to get notifications about new
+ * connector user registration
+ */
+#if 0
static int cn_test_want_notify(void)
{
struct cn_ctl_msg *ctl;
@@ -117,6 +123,7 @@ nlmsg_failure:
kfree_skb(skb);
return -EINVAL;
}
+#endif
static u32 cn_test_timer_counter;
static void cn_test_timer_func(unsigned long __data)
--
1.6.0.6
next prev parent reply other threads:[~2009-05-20 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 5:34 [PATCH -tip] Documentation/connector/cn_test.c remove unused cn_test_want_notify() Jaswinder Singh Rajput
2009-05-20 7:22 ` Evgeniy Polyakov
2009-05-20 7:42 ` Jaswinder Singh Rajput [this message]
2009-05-20 9:27 ` Evgeniy Polyakov
2009-05-27 8:37 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242805348.3260.52.camel@localhost.localdomain \
--to=jaswinder@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).