From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756404AbZETHnQ (ORCPT ); Wed, 20 May 2009 03:43:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754096AbZETHm7 (ORCPT ); Wed, 20 May 2009 03:42:59 -0400 Received: from hera.kernel.org ([140.211.167.34]:42174 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754019AbZETHm7 (ORCPT ); Wed, 20 May 2009 03:42:59 -0400 Subject: Re: [PATCH -tip] Documentation/connector/cn_test.c remove unused cn_test_want_notify() From: Jaswinder Singh Rajput To: Evgeniy Polyakov Cc: Ingo Molnar , Andrew Morton , David Miller , x86 maintainers , LKML In-Reply-To: <20090520072224.GA19823@ioremap.net> References: <1242797693.3260.15.camel@localhost.localdomain> <20090520072224.GA19823@ioremap.net> Content-Type: text/plain Date: Wed, 20 May 2009 13:12:28 +0530 Message-Id: <1242805348.3260.52.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2009-05-20 at 11:22 +0400, Evgeniy Polyakov wrote: > On Wed, May 20, 2009 at 11:04:53AM +0530, Jaswinder Singh Rajput (jaswinder@kernel.org) wrote: > > > > Currently cn_test_want_notify() is not having any user. > > Do not remove it, disable with ifdef if you want, it is an example > of how to get notifications about new connector user registration. > [PATCH -tip] Documentation/connector/cn_test.c comment unused cn_test_want_notify() Currently cn_test_want_notify() is not having any user. So adding ifdef and comment which tells to not remove it. Signed-off-by: Jaswinder Singh Rajput --- Documentation/connector/cn_test.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/Documentation/connector/cn_test.c b/Documentation/connector/cn_test.c index 6977c17..f688eba 100644 --- a/Documentation/connector/cn_test.c +++ b/Documentation/connector/cn_test.c @@ -41,6 +41,12 @@ void cn_test_callback(void *data) msg->seq, msg->ack, msg->len, (char *)msg->data); } +/* + * Do not remove this function even if no one is using it as + * this is an example of how to get notifications about new + * connector user registration + */ +#if 0 static int cn_test_want_notify(void) { struct cn_ctl_msg *ctl; @@ -117,6 +123,7 @@ nlmsg_failure: kfree_skb(skb); return -EINVAL; } +#endif static u32 cn_test_timer_counter; static void cn_test_timer_func(unsigned long __data) -- 1.6.0.6