From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751034AbZEUFKd (ORCPT ); Thu, 21 May 2009 01:10:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751089AbZEUFKS (ORCPT ); Thu, 21 May 2009 01:10:18 -0400 Received: from hera.kernel.org ([140.211.167.34]:53486 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbZEUFKR (ORCPT ); Thu, 21 May 2009 01:10:17 -0400 Subject: Re: [PATCH 3/10 -tip] x86: Add cpufeatures for Advanced Power Management From: Jaswinder Singh Rajput To: "H. Peter Anvin" Cc: Thomas Gleixner , Ingo Molnar , Robert Richter , Dave Jones , LKML , x86 maintainers In-Reply-To: <4A144C4D.7070205@kernel.org> References: <1242142530.2547.11.camel@ht.satnam> <1242142623.2547.13.camel@ht.satnam> <1242142692.2547.15.camel@ht.satnam> <1242142753.2547.16.camel@ht.satnam> <1242155190.2492.73.camel@ht.satnam> <1242395277.3082.24.camel@localhost.localdomain> <1242745272.3169.13.camel@localhost.localdomain> <4A12E122.1020009@kernel.org> <1242803735.3260.44.camel@localhost.localdomain> <4A144C4D.7070205@kernel.org> Content-Type: text/plain Date: Thu, 21 May 2009 10:39:27 +0530 Message-Id: <1242882567.3191.5.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2009-05-20 at 11:30 -0700, H. Peter Anvin wrote: > Jaswinder Singh Rajput wrote: > > > > I think better I will show with the coding to get the clear picture. > > > > Currently we are using hardcoded x86_capability as [0], [2], [4], [5]. > > > > Thomas prefer to use constant so may be we can define current system as: > > > > enum { > > CPUID_0000_0001_EDX = 0, /* 0x00000001 edx */ > > CPUID_8000_0001_EDX, /* 0x80000001 edx */ > > CPUID_8086_0001_EDX, /* 0x80860001 edx */ > > CPUID_SOFT_MISC1, /* Software Misc1 */ > > CPUID_0000_0001_ECX, /* 0x00000001 ecx */ > > CPUID_C000_0001_EDX, /* 0xC0000001 edx */ > > CPUID_8000_0001_ECX, /* 0x80000001 ecx */ > > CPUID_SOFT_MISC2, /* Software Misc2 */ > > CPUID_SOFT_VIRTUAL, /* Software Virtualization */ > > }; > > > > This really seems clumsy to me. We don't refer to the individual words > all that often; and more importantly, I think it'd be hard to get rid of > all the places where the words are referenced. > OK. It was thomas request. I hope this explanation will be enough and thomas have no objection in Advanced Power Management's cpufeatures series. Ingo: should I resend new cpufeatures series, or you can use this one. Thanks, -- JSR