public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Chris Sanford <crsanford@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	peterz@infradead.org
Subject: Re: [PATCH] include KERN_* constant in printk calls
Date: Thu, 21 May 2009 15:09:52 +1000	[thread overview]
Message-ID: <1242882592.4784.44.camel@concordia> (raw)
In-Reply-To: <20090521024635.GA4030@chrisubuntu-laptop>

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

On Wed, 2009-05-20 at 19:46 -0700, Chris Sanford wrote:
> Here is the updated patch for sched.c. It replaces all the printk calls with their
> corresponding pr_* call. The five KERN_DEBUG calls have been changed to
> pr_info.

Switching from KERN_DEBUG to KERN_INFO means the messages will now
appear for most people, whereas previously they didn't. I'm not sure
that's a great idea.

If you really want to convert them, then I think we need a macro for
KERN_DEBUG but not conditionally compiled like pr_debug.

I sent a patch for that once, but I don't think anyone liked it, and
I've lost it now :D

cheers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2009-05-21  5:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 23:31 [PATCH] include KERN_* constant in printk calls Chris Sanford
2009-05-19  9:00 ` Ingo Molnar
2009-05-20  4:32   ` Chris Sanford
2009-05-20  8:37     ` Ingo Molnar
2009-05-21  2:46       ` Chris Sanford
2009-05-21  3:30         ` Joe Perches
2009-05-21  4:09           ` Chris Sanford
2009-05-21  5:09         ` Michael Ellerman [this message]
2009-05-21  9:09           ` walter harms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242882592.4784.44.camel@concordia \
    --to=michael@ellerman.id.au \
    --cc=crsanford@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox