Re: [PATCH] sx tty_driver add .owner field remove MOD_INC_DEC_USE_COUNT

Rusty Russell
2003-05-30T07:53:20Z

In message <12430000.1054244110@w-hlinder> you write:
> --On Thursday, May 29, 2003 12:02:50 PM -0700 Greg KH <greg@kroah.com> wrote:
>
> >
> > Ick, this patch should be reverted, it should not be removing
> > sx_hungup() for no reason. I think Hanna agrees with this.
>
> Yup. Sorry. Not sure what happened there. Here is the patch
> to replace the sx_hangup function. This is based off 2.5.70-bk3
> and I have compiled it but dont have the hardware to test it.

Yes, but I don't think you need to put back the comment about
decrementing use counts 8)

> +/* I haven't the foggiest why the decrement use count has to happen
> + here. The whole linux serial drivers stuff needs to be redesigned.
> + My guess is that this is a hack to minimize the impact of a bug
> + elsewhere. Thinking about it some more. (try it sometime) Try
> + running minicom on a serial port that is driven by a modularized
> + driver. Have the modem hangup. Then remove the driver module. Then
> + exit minicom. I expect an "oops". -- REW */

Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.