Re: [loongson-PATCH-v1 16/27] Add Siliconmotion 712 framebuffer driver

Wu Zhangjin
2009-05-29T19:52:06Z

Hi,

On Fri, 2009-05-29 at 15:29 +0200, Simon Braunschmidt wrote:
> Hi Wu Zhangjin
>
> I applied your patch cleanly and run it on a i486SX (little endian)
> embedded computing board.

thanks very much for testing it in a non-mips platform!

> This provides a huge performance benefit compared to vesa framebuffer,
> so thanks a lot for the contribution.
>

the thanks should goes to the original authors from Silicon Motion
Technology Corp. including Ge Wang and Boyod.Yang. I just cleaned it up.

> I tested it in both the library-accelerated (cfb...) and hardware
> accelerated codepaths, with no problems. Tested with qt-embedded 4.5.1.
>
> As i have seen lots of functionality are guarded by
> #ifdef __BIG_ENDIAN
>
> Is there a way to setup a different mode than 1024x600 on
> kernel-commandline or from userspace, e.g. with fbset?
>

seems we can change it in userspace, i have changed it to 800X480 in a
7inch yeeloong2f laptop in the "control center" of KDE desktop.

or perhaps you can configure it in the Xorg.conf directly.

> What I currently do is
> picking appropriate values form the table VGAMode in smtcfb.h and
> hardcoding them.
>
> I tried 800x600x16bit@60hz, which worked also, but 1024x768x24bit@60hz
> left me with a corrupted display output (distored colors, missing
> regions), i did not check further wheter it also crashed.
>

I will try to check it, but in reality, I'm not familiar with it, so
maybe very hard and slow to check it. I will forward this E-mail to the
original authors, hope they can give some help.

> I dont know wheter i am subscribed and this will make it through to lkml
> and linux-mips, feel free to cite me if you want.
>
> Also if you want you may add my
>
> Tested-by: Simon Braunschmidt <sbraun@emlix.com>
>

added.

>
> see also attached a patch for the debug messages
>
>

Applied.

thanks!
Wu Zhangjin
>
> From addec9a5a27512621c538a2f799e31e07720cb9c Mon Sep 17 00:00:00 2001
> From: Simon Braunschmidt <sbraun@emlix.com>
> Date: Fri, 29 May 2009 15:03:51 +0200
> Subject: [PATCH] [video] fix debug messages in smtcfb
>
> when defining #DEBUG
> ---
> drivers/video/smi/smtcfb.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/smi/smtcfb.c b/drivers/video/smi/smtcfb.c
> index 33ce878..ebc6371 100644
> --- a/drivers/video/smi/smtcfb.c
> +++ b/drivers/video/smi/smtcfb.c
> @@ -44,6 +44,8 @@
> #include "smtcfb.h"
> #include "smtc2d.h"
>
> +#define DEBUG
> +
> #ifdef DEBUG
> #define smdbg(format, arg...) printk(KERN_DEBUG format , ## arg)
> #else
> @@ -1087,7 +1089,7 @@ static int __init sm712be_setup(char *options)
> sm712be_flag = 0;
> if (!options || !*options) {
> retval = 1;
> - smdbg("\n No sm712be parameter\n", __LINE__);
> + smdbg("\n No sm712be parameter\n");
> }
> if (!retval && strstr(options, "enable"))
> sm712be_flag = 1;
> @@ -1113,7 +1115,7 @@ static int __init sm712vga_setup(char *options)
>
> if (!options || !*options) {
> retval = 1;
> - smdbg("\n No vga parameter\n", __LINE__);
> + smdbg("\n No vga parameter\n");
> }
>
> screen_info.lfb_width = 0;
> --
> 1.6.3.rc0.1.gf800
>
>
>