From: Peter Zijlstra <peterz@infradead.org>
To: john stultz <johnstul@us.ibm.com>
Cc: Linus Walleij <linus.ml.walleij@gmail.com>,
Paul Mundt <lethal@linux-sh.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Victor <linux@maxim.org.za>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk,
John Stultz <johnstul@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched: Support current clocksource handling in fallback sched_clock().
Date: Tue, 26 May 2009 22:55:09 +0200 [thread overview]
Message-ID: <1243371309.6600.8.camel@laptop> (raw)
In-Reply-To: <1243370439.3275.13.camel@localhost>
On Tue, 2009-05-26 at 13:40 -0700, john stultz wrote:
> On Tue, 2009-05-26 at 22:30 +0200, Peter Zijlstra wrote:
> > On Tue, 2009-05-26 at 13:23 -0700, john stultz wrote:
> > > Overall, I'd probably suggest thinking this through a bit more. At some
> > > point doing this right will cause sched_clock() to be basically the same
> > > as ktime_get(). So why not just use that instead of remaking it?
> >
> > simply because we don't require the strict global monotonicy for
> > scheduling as we do from a regular time source (its nice to have
> > though).
> >
> > That means that on x86 we can always use TSC for sched_clock(), even
> > when its quite unsuitable for ktime.
>
> Right, but I guess what I'm asking is can this be a bit better defined?
>
> If we are going to use clocksources (or cyclecounters - an area I need
> to clean up soon), it would be good to get an idea of what is expected
> of the sched_clock() interface.
>
> So TSC good, HPET bad. Why?
Because TSC is a few cycles to read, and you can factorize a largish
prime while doing an HPET read :-)
> Is latency all we care about? How bad would
> the TSC have to be before we wouldn't want to use it?
Anything better than jiffies ;-)
For sched_clock() we want something high-res that is monotonic per cpu
and has a bounded drift between cpus in the order of jiffies.
Look at kernel/sched_clock.c for what we do to make really shitty TSC
conform to the above requirements.
next prev parent reply other threads:[~2009-05-26 20:56 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 6:15 [PATCH] sched: Support current clocksource handling in fallback sched_clock() Paul Mundt
2009-05-26 14:31 ` Linus Walleij
2009-05-26 14:38 ` Peter Zijlstra
2009-05-26 20:17 ` Thomas Gleixner
2009-05-26 23:08 ` Paul Mundt
2009-05-26 23:13 ` Paul Mundt
2009-05-26 23:25 ` john stultz
2009-05-26 23:44 ` Paul Mundt
2009-05-27 0:18 ` Thomas Gleixner
2009-05-27 0:22 ` john stultz
2009-05-27 0:26 ` Paul Mundt
2009-05-27 1:09 ` john stultz
2009-05-27 0:27 ` Thomas Gleixner
2009-05-26 23:49 ` Thomas Gleixner
2009-05-27 0:15 ` Paul Mundt
2009-05-27 16:25 ` Daniel Walker
2009-05-28 8:44 ` Paul Mundt
2009-05-28 9:19 ` Paul Mundt
2009-05-28 9:34 ` Peter Zijlstra
2009-05-28 11:09 ` Paul Mundt
2009-05-28 12:22 ` Thomas Gleixner
2009-05-28 12:40 ` Peter Zijlstra
2009-05-28 12:42 ` Paul Mundt
2009-05-28 12:53 ` Thomas Gleixner
2009-05-28 12:59 ` Peter Zijlstra
2009-05-28 13:20 ` Paul Mundt
2009-05-28 16:13 ` Daniel Walker
2009-05-28 16:32 ` Peter Zijlstra
2009-05-28 16:40 ` Paul Mundt
2009-05-28 16:52 ` Daniel Walker
2009-05-28 16:58 ` Paul Mundt
2009-05-28 17:38 ` Daniel Walker
2009-05-28 17:46 ` Thomas Gleixner
2009-05-28 17:53 ` Paul Mundt
2009-05-28 18:10 ` Daniel Walker
2009-05-28 18:27 ` Paul Mundt
2009-05-28 19:04 ` Daniel Walker
2009-05-28 19:34 ` Paul Mundt
2009-05-28 19:41 ` Daniel Walker
2009-05-28 23:37 ` Paul Mundt
2009-05-28 18:44 ` Thomas Gleixner
2009-05-28 17:00 ` Thomas Gleixner
2009-05-28 17:07 ` John Stultz
2009-05-26 20:23 ` john stultz
2009-05-26 20:30 ` Peter Zijlstra
2009-05-26 20:40 ` john stultz
2009-05-26 20:55 ` Peter Zijlstra [this message]
2009-05-26 23:00 ` john stultz
2009-05-26 23:24 ` Mangalampalli, JayantX
2009-05-27 0:04 ` Thomas Gleixner
2009-05-26 23:39 ` Thomas Gleixner
2009-05-27 6:58 ` Peter Zijlstra
2009-05-26 20:39 ` Thomas Gleixner
2009-05-26 14:43 ` Paul Mundt
2009-05-26 14:50 ` Peter Zijlstra
2009-05-26 14:53 ` Paul Mundt
2009-05-26 15:02 ` Matthieu CASTET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243371309.6600.8.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hskinnemoen@atmel.com \
--cc=johnstul@linux.vnet.ibm.com \
--cc=johnstul@us.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox