From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: Oops in usb-serial with keyspan adapter on current upstream
Date: Wed, 27 May 2009 08:28:05 +1000 [thread overview]
Message-ID: <1243376885.17847.15.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0905261005000.3584-100000@iolanthe.rowland.org>
On Tue, 2009-05-26 at 10:06 -0400, Alan Stern wrote:
> On Tue, 26 May 2009, Benjamin Herrenschmidt wrote:
>
> > Well, both our patches are bogus in the sense that they will leak
> > the stuff in the port structure.
>
> That's not true at all. Take a look at the destroy_serial() routine.
Right... hrm. This is an horrible mess, I can't wait to see that
refcount going wrong and things trying to double free or leaking the
structure.
Oh well, fix it the way your want, I don't care as long as it's fixed.
This driver is just plain horrible.
Ben.
next prev parent reply other threads:[~2009-05-26 22:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 0:07 Oops in usb-serial with keyspan adapter on current upstream Benjamin Herrenschmidt
2009-05-18 15:06 ` Alan Stern
2009-05-19 1:05 ` Benjamin Herrenschmidt
2009-05-19 1:49 ` Benjamin Herrenschmidt
2009-05-19 14:39 ` Alan Stern
2009-05-25 6:43 ` Benjamin Herrenschmidt
2009-05-25 15:17 ` Alan Stern
2009-05-25 22:00 ` Benjamin Herrenschmidt
2009-05-26 14:06 ` Alan Stern
2009-05-26 22:28 ` Benjamin Herrenschmidt [this message]
2009-05-27 2:13 ` Alan Stern
2009-05-27 3:30 ` Benjamin Herrenschmidt
2009-05-27 3:30 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243376885.17847.15.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).