[PATCH] misc: ntsync: mark driver as "broken" to prevent from building

[PATCH] misc: ntsync: mark driver as "broken" to prevent from building

[Greg Kroah-Hartman]

The ntsync code is only partially enabled in the kernel at this point in
time, creating the device node and that's about it.  Don't confuse
systems that expect to see a working ntsync interface by teasing it with
this basic structure at this point in time, so mark the code as "broken"
so that it is not built and enabled just yet.

Once the rest of the code is accepted, this will be reverted so that the
driver can be correctly built and used, but for now, this is the safest
way forward.

Cc: Elizabeth Figura <zfigura@codeweavers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/misc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 2907b5c23368..faf983680040 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -507,6 +507,7 @@ config OPEN_DICE
 
 config NTSYNC
 	tristate "NT synchronization primitive emulation"
+	depends on BROKEN
 	help
 	  This module provides kernel support for emulation of Windows NT
 	  synchronization primitives. It is not a hardware driver.
-- 
2.45.0

Re: [PATCH] misc: ntsync: mark driver as "broken" to prevent from building

[Elizabeth Figura]

On Tuesday, May 14, 2024 2:16:51 AM CDT Greg Kroah-Hartman wrote:
> The ntsync code is only partially enabled in the kernel at this point in
> time, creating the device node and that's about it.  Don't confuse
> systems that expect to see a working ntsync interface by teasing it with
> this basic structure at this point in time, so mark the code as "broken"
> so that it is not built and enabled just yet.
> 
> Once the rest of the code is accepted, this will be reverted so that the
> driver can be correctly built and used, but for now, this is the safest
> way forward.

Reviewed-by: Elizabeth Figura <zfigura@codeweavers.com>

--

I was even thinking of suggesting something like this myself. Sorry for
taking so long to get the rest of the patches into acceptable shape...

Re: [PATCH] misc: ntsync: mark driver as "broken" to prevent from building

[Greg Kroah-Hartman]

On Tue, May 14, 2024 at 04:45:13PM -0500, Elizabeth Figura wrote:
> On Tuesday, May 14, 2024 2:16:51 AM CDT Greg Kroah-Hartman wrote:
> > The ntsync code is only partially enabled in the kernel at this point in
> > time, creating the device node and that's about it.  Don't confuse
> > systems that expect to see a working ntsync interface by teasing it with
> > this basic structure at this point in time, so mark the code as "broken"
> > so that it is not built and enabled just yet.
> > 
> > Once the rest of the code is accepted, this will be reverted so that the
> > driver can be correctly built and used, but for now, this is the safest
> > way forward.
> 
> Reviewed-by: Elizabeth Figura <zfigura@codeweavers.com>
> 
> --
> 
> I was even thinking of suggesting something like this myself. Sorry for
> taking so long to get the rest of the patches into acceptable shape...

No worries at all, I'll go queue this up today.  Thanks for the review!

greg k-h