linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: Oops in usb-serial with keyspan adapter on current upstream
Date: Wed, 27 May 2009 13:30:30 +1000	[thread overview]
Message-ID: <1243395030.17847.55.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0905251116250.23874-100000@netrider.rowland.org>


> Very clever.  Does this simpler patch also fix the problem?

Yes it does, thanks.

Tested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
> 
> Index: usb-2.6/drivers/usb/serial/usb-serial.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/serial/usb-serial.c
> +++ usb-2.6/drivers/usb/serial/usb-serial.c
> @@ -974,6 +974,7 @@ int usb_serial_probe(struct usb_interfac
>  		if (retval > 0) {
>  			/* quietly accept this device, but don't bind to a
>  			   serial port as it's about to disappear */
> +			serial->num_ports = 0;
>  			goto exit;
>  		}
>  	}
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


      parent reply	other threads:[~2009-05-27  3:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18  0:07 Oops in usb-serial with keyspan adapter on current upstream Benjamin Herrenschmidt
2009-05-18 15:06 ` Alan Stern
2009-05-19  1:05   ` Benjamin Herrenschmidt
2009-05-19  1:49     ` Benjamin Herrenschmidt
2009-05-19 14:39       ` Alan Stern
2009-05-25  6:43         ` Benjamin Herrenschmidt
2009-05-25 15:17           ` Alan Stern
2009-05-25 22:00             ` Benjamin Herrenschmidt
2009-05-26 14:06               ` Alan Stern
2009-05-26 22:28                 ` Benjamin Herrenschmidt
2009-05-27  2:13                   ` Alan Stern
2009-05-27  3:30                     ` Benjamin Herrenschmidt
2009-05-27  3:30             ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243395030.17847.55.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).