Re: [PATCH 01/20] sysfs: Implement sysfs_rename_link

Kay Sievers
2009-05-21T10:06:48Z

On Thu, May 21, 2009 at 07:35, Tejun Heo <tj@kernel.org> wrote:
> Eric W. Biederman wrote:
>> +int sysfs_rename_link(struct kobject *kobj, struct kobject *targ,
>> +                     const char *old, const char *new)
>> +{
>> +     sysfs_remove_link(kobj, old);
>> +     return sysfs_create_link(kobj, targ, new);
>> +}
>> +
>
> Removal and creation are done in the reverse order compared to the one
> used in device rename.  The important difference is that previously
> failed operation was noop whereas it now would remove the current
> link.  I think the old order is correct.

The target string is composed on-demand, and it always points to the
same kobject and *targ is not needed, right?

Can't we just change the name of the link, instead of removing and
re-creating the entire thing, and all these issues go away?

Thanks,
Kay