Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories.

Kay Sievers
2009-05-25T10:54:06Z

On Mon, May 25, 2009 at 09:53, Eric W. Biederman <ebiederm@xmission.com> wrote:
> ebiederm@xmission.com (Eric W. Biederman) writes:

> Currently I expect that those attributes that are not deleted may
> actually be bugs as well.  If a driver manually adds sysfs files after
> device_create/device_register the uevent will have already been sent
> and you can not safely use those attributes in when processing a hotplug
> event.

That's true, and would be good to fix. I guess we need to come up with
a way of maintaining binary attributes in the same way as "default"
attributes. Today they need to be created manually.

Maybe we can get your patch series in, with the version that removes
the files, but warns on existing directories, and work on fixing the
users, and possible remove the deletion of files when we fixed all the
current users?

Thanks,
Kay