Re: [RFC] [PATCH] Device Tree on ARM platform

Russell King
2009-05-27T19:29:47Z

On Wed, May 27, 2009 at 02:08:42PM -0500, Scott Wood wrote:
> Russell King wrote:
>> No one has brought that up on the ARM mailing lists - so does this issue
>> really exist? All of the stuff I see on the ARM lists seems to be well
>> behaved and following our existing model - even vendor stuff (supplied
>> to me under NDA) seems to generally get this kind of stuff right.
>
> I'm just going by what I've seen on the u-boot list lately. What is the
> existing ARM Linux model for passing MAC addresses, so that we can point
> people to that when they try to get u-boot to do silly things?

To program them into the hardware registers, which is not what we in
the ARM community say, but it's what the _network_ guys tell people
they should be doing.

I've suggested in the past having a standard kernel parameter such
that you can specify a mac address on a per-device basis in a totally
platform independent way, but the network folk don't like that idea.

>>> You can, if you want. But you'll need extra glue code that
>>> understands the individual bindings. IMHO that logic is usually
>>> better off in the driver itself, but if you really need platform
>>> code to involve itself in some way (such as providing callbacks),
>>> then exceptions can be made.
>>
>> No it is not. Device drivers are best written to support devices, and
>> the platform specific code should not be anywhere near them. Platform
>> specific code to handle oddities of platforms should be totally separate
>> from the device driver itself.
>
> I'm not talking about platform specific code, I'm talking about code to
> retrieve information about a device from the device tree. There would
> not be separate instances of this for "platforms X, Y and Z", just one
> of_platform binding in each driver. It's no different than having a
> platform bus binding, except in the data structures used.

I really don't see what OF buys us then, apart from additional dependencies
that have to be correct for the kernel to work. I can only see disadvantages
if all OF is, is a way to pass some file to the kernel to (effectively) tell
it which drivers to use.

>> smc91x is a prime example of the kind of information drivers need - base
>> address and irq are very much insufficient to describe how this device is
>> connected. There's much more information required to specify this device
>> fully, and throwing it into the driver doesn't work. We've been there
>> and proven that point.
>
> The device tree is quite capable of expressing information beyond
> addresses and interrupts.

Bus width? Register offset spacing? SMC LED configuration? Whether
to use the hardware wait signal from the SMC?

If you're going to say yes to all that, I'm going to start asking how
you cope with verifying that the data for ethernet driver A doesn't
get accidentally used for ethernet driver B.

I assume you have some kind of compiler, which needs a set of specification
files to tell it what's required for each driver which is OF compatible.
If not, I can see no way for OF trees to ever be safe and correct.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/