Re: [RFC] [PATCH] Device Tree on ARM platform

Russell King
2009-05-27T18:06:30Z

On Wed, May 27, 2009 at 11:23:29AM -0500, Scott Wood wrote:
> That removes the ability to use the device tree to pass information from
> the bootloader, such as MAC addresses and clock frequencies. On the
> u-boot list, you'll find people trying such hacks (which were rightly
> NACKed) as passing the information in the device's volatile registers
> (which the Linux driver must then not reset) to deal with ARM Linux's
> lack of this ability.

No one has brought that up on the ARM mailing lists - so does this issue
really exist? All of the stuff I see on the ARM lists seems to be well
behaved and following our existing model - even vendor stuff (supplied
to me under NDA) seems to generally get this kind of stuff right.

Basically, what I'm saying is that I have seen no evidence to support
the argument you're making, but I'm not saying you're wrong or that it
doesn't happen.

>> Robert> - The oftree layering is fundamentally broken. We already
>> Robert> have a sane abstraction for arbitrary hardware in the kernel:
>> Robert> platform devices. Why not instanciate platform devices from
>> Robert> a generic oftree core?
>
> You can, if you want. But you'll need extra glue code that understands
> the individual bindings. IMHO that logic is usually better off in the
> driver itself, but if you really need platform code to involve itself in
> some way (such as providing callbacks), then exceptions can be made.

No it is not. Device drivers are best written to support devices, and
the platform specific code should not be anywhere near them. Platform
specific code to handle oddities of platforms should be totally separate
from the device driver itself.

For example, see the mess that is cs89x0, which isn't a platform driver
(or any kind of driver model driver). It's full of individual platform
specific hacks to make it work on platforms X, Y and Z. The same was
true of the smc91x driver (which is a platform driver but wasn't done
in a generic way.) smc91x was very quickly becoming a big problem to
maintain and use because of all the platform specific junk being shoe-
horned into the driver. smc91x eventually got fixed. cs89x0 hasn't.

smc91x is a prime example of the kind of information drivers need - base
address and irq are very much insufficient to describe how this device is
connected. There's much more information required to specify this device
fully, and throwing it into the driver doesn't work. We've been there
and proven that point.

So, repeat this mantra: device drivers should contain no platform specifics.
Platform specifics should be separated from the driver and implemented by
platform support code.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/