From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760664AbZE2Opc (ORCPT ); Fri, 29 May 2009 10:45:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758079AbZE2OpY (ORCPT ); Fri, 29 May 2009 10:45:24 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:43934 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754821AbZE2OpX (ORCPT ); Fri, 29 May 2009 10:45:23 -0400 Subject: Re: [perfmon2] comments on Performance Counters for Linux (PCL) From: Carl Love To: Geert Uytterhoeven Cc: Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Philip Mucci , LKML , Andi Kleen , Paul Mackerras , Maynard Johnson , Andrew Morton , eranian@gmail.com, perfmon2-devel In-Reply-To: References: <7c86c4470905280758y6d359823h2a7517dfecb115e6@mail.gmail.com> <1243527919.6645.75.camel@laptop> <4A1EFCC2.80805@linux.vnet.ibm.com> <20090528213532.GA8589@elte.hu> <18975.7470.792842.173625@cargo.ozlabs.ibm.com> <20090529071914.GB3157@elte.hu> Content-Type: text/plain; charset=utf-8 Date: Fri, 29 May 2009 07:42:39 -0700 Message-Id: <1243608160.6534.46.camel@carll-linux-desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-05-29 at 10:21 +0200, Geert Uytterhoeven wrote: > On Fri, 29 May 2009, Ingo Molnar wrote: > > * Paul Mackerras wrote: > > > Ingo Molnar writes: > > > > * Corey Ashford wrote: > > > > >> So you're suggesting to artificually strech periods by say > > > > >> composing a single overflow from smaller ones, ignoring the > > > > >> intermediate overflow events? > > > > >> > > > > >> That sounds doable, again, patch welcome. > > > > > > > > > > I definitely agree with Stephane's point on this one. I had > > > > > assumed that long irq_periods (longer than the width of the > > > > > counter) would be synthesized as you suggest. If this is not the > > > > > case, PCL should be changed so that it does, -or- at a minimum, > > > > > the user should get an error back stating that the period is too > > > > > long for the hardware counter. > > > > > > > > this looks somewhat academic - at least on x86, even the fastest > > > > events (say cycles) with a 32 bit overflow means one event per > > > > second on 4GB. That's not a significant event count in practice. > > > > What's the minimum width we are talking about on Power? > > > > > > 32 bits, but since the top bit is effectively a level-sensitive > > > interrupt request, the maximum period in hardware is 2^31 counts. > > > > > > However, I already support 64-bit interrupt periods (well, 63-bit > > > actually) on powerpc by only calling perf_counter_overflow() when > > > counter->hw.period_left becomes <= 0, and arranging to set the > > > hardware counter to 0 if counter->hw.period_left is >= 0x80000000. > > > It's a tiny amount of code to handle it, really. > > > > No argument about that - just wanted to know whether there's any > > real practical effect beyond the nitpicking factor ;-) > > I never really dived into this stuff, but ISTR there are some 16-bit counters > on CELL? Is that correct? FYI, the counters on CELL are configurable. You can have up to eight 16 bit count counters or you can combine counters i and i=1 (where i=0,2,4,6) into 32 bit counters. This allows you to have some 16 and some 32 bit counters at the same time. > > With kind regards, > > Geert Uytterhoeven > Software Architect > Techsoft Centre > > Technology and Software Centre Europe > The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium > > Phone: +32 (0)2 700 8453 > Fax: +32 (0)2 700 8622 > E-mail: Geert.Uytterhoeven@sonycom.com > Internet: http://www.sony-europe.com/ > > A division of Sony Europe (Belgium) N.V. > VAT BE 0413.825.160 · RPR Brussels > Fortis · BIC GEBABEBB · IBAN BE41293037680010 > > ------------------------------------------------------------------------------ > Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT > is a gathering of tech-side developers & brand creativity professionals. Meet > the minds behind Google Creative Lab, Visual Complexity, Processing, & > iPhoneDevCamp as they present alongside digital heavyweights like Barbarian > Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com > _______________________________________________ > perfmon2-devel mailing list > perfmon2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/perfmon2-devel