From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbZEaRd2 (ORCPT ); Sun, 31 May 2009 13:33:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750956AbZEaRdU (ORCPT ); Sun, 31 May 2009 13:33:20 -0400 Received: from waste.org ([66.93.16.53]:48899 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750695AbZEaRdU (ORCPT ); Sun, 31 May 2009 13:33:20 -0400 Subject: Re: [PATCH] TXx9: Add TX4939 RNG support From: Matt Mackall To: Atsushi Nemoto Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au In-Reply-To: <20090601.022335.200392387.anemo@mba.ocn.ne.jp> References: <1243350141-883-2-git-send-email-anemo@mba.ocn.ne.jp> <20090601.015755.21367568.anemo@mba.ocn.ne.jp> <1243789289.22069.25.camel@calx> <20090601.022335.200392387.anemo@mba.ocn.ne.jp> Content-Type: text/plain Date: Sun, 31 May 2009 12:32:50 -0500 Message-Id: <1243791170.22069.28.camel@calx> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-06-01 at 02:23 +0900, Atsushi Nemoto wrote: > On Sun, 31 May 2009 12:01:29 -0500, Matt Mackall wrote: > > > > Not clear to me how this works when this is a module? > > > > > > This patch add a registration of a platform device for RNG to vmlinux. > > > And the other patch add a driver module for the RNG. This strategy is > > > fairly common for SoCs or embedded platforms. > > > > If your driver is built as a module (which your patch allows), the above > > won't work, right? > > No, the rng driver can be used regardless of module or built-in, as > like as other platform drivers. Any special issue for hw_rng? I found the source of my confusion: you've given the init function in both files exactly the same name. So when I saw .._init at the bottom of the second patch, I assumed it was referring to the possibly not loaded driver's init code. -- http://selenic.com : development and support for Mercurial and Linux