Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family implementation

Johannes Berg
2009-06-04T14:15:53Z

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Thu, 2009-06-04 at 18:10 +0400, Dmitry Eremin-Solenikov wrote:

> We do try to fit the lines into 80 chars, but when that seems logical.
> I strongly dislike breaking comparations between lines.

There are a whole bunch of improvements possible at this particular
spot:

switch (X) {
case Y:
if (A) {
...
}
break;
...
}

can be written as

switch (X) {
case Y:
if (!A)
break;
...
break;
}

and

for (...) {
if (A) {
...
break;
}
}

can be written as

for (...) {
if (!A)
continue;
...
break;
}

etc.

Show some creativity!

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]