From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jan Scholz <scholz@fias.uni-frankfurt.de>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Adrian Bunk <bunk@kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [regression, bisected] adb trackpad disappears after suspend to ram
Date: Tue, 02 Jun 2009 14:49:24 +1000 [thread overview]
Message-ID: <1243918164.5308.23.camel@pasglop> (raw)
In-Reply-To: <200906011836.15507.rjw@sisk.pl>
> So, it seems we lose and interrupt during resume and that confuses the
> ADB controller driver or something like this. Do you use the keyboard or
> the trackpad as a wake-up device?
>
> Please additionally try to go back to the original code, put
> 'sleepy_trackpad = 1' at the beginning of do_adb_reset_bus() in
> drivers/macintosh/adb.c and see if the problem is reproducible with that.
Well, the ADB controller is also the PMU (drivers/macintosh/via-pmu.c)
which is also the system controller, handles the actual sleep state,
etc... :-)
That code is a bit itchy around the edges. I'm not sure it would have
lost an interrupt, that sounds more like losing an IRQ would have broken
it completely but it's not -impossible- (especially if it's the external
GPIO or CB1 interrupt that notifies of an incoming ADB message).
I haven't managed to reproduce the problem yet here though. I'll see if
I can with a titanium powerbook I have somewhere in storage that might
be a bit closer to your machine than the wallstreet powerbook I've been
using to test at work :-) My other powerbook test machine uses a USB
trackpad.
Cheers,
Ben.
prev parent reply other threads:[~2009-06-02 4:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 15:44 [regression] adb trackpad disappears after suspend to ram Jan Scholz
2009-05-28 7:59 ` [regression, bisected] " Jan Scholz
2009-05-28 16:58 ` Rafael J. Wysocki
2009-05-28 22:23 ` Benjamin Herrenschmidt
2009-05-28 22:39 ` Jan Scholz
2009-05-29 18:10 ` Rafael J. Wysocki
2009-06-01 13:44 ` Jan Scholz
2009-06-01 16:36 ` Rafael J. Wysocki
2009-06-01 22:34 ` Jan Scholz
2009-06-01 22:42 ` Rafael J. Wysocki
2009-06-01 22:52 ` Benjamin Herrenschmidt
[not found] ` <200906031202.28916.rjw@sisk.pl>
2009-06-03 12:18 ` Jan Scholz
[not found] ` <200906032200.55563.rjw@sisk.pl>
[not found] ` <200906032220.19915.rjw@sisk.pl>
2009-06-03 22:17 ` [linux-pm] " Jan Scholz
2009-09-23 3:32 ` Benjamin Herrenschmidt
2009-09-23 13:38 ` Rafael J. Wysocki
2009-09-23 21:28 ` Benjamin Herrenschmidt
2009-10-07 17:10 ` Jan Scholz
2009-10-07 20:18 ` Rafael J. Wysocki
2009-09-23 23:12 ` Jan Scholz
2009-06-02 4:49 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243918164.5308.23.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rjw@sisk.pl \
--cc=scholz@fias.uni-frankfurt.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox