Re: [PATCH 17/39] kbuild: fix header export when __ASSEMBLY__ is used

Jaswinder Singh Rajput
2009-06-06T05:44:38Z

Hello Sam, Russell,

On Sat, 2009-06-06 at 00:41 +0000, Arnd Bergmann wrote:
> On Friday 05 June 2009 11:42:35 pm Sam Ravnborg wrote:
> > Because it does not know __ASSEMBLY__ it does not
> > detect that htis is not for userspace.
> > This caused too much code to be exported, and headers_check barfed
> > over this code.
> >
> > For arm this fixes following "make headers_check" warning:
> > /usr/include/asm/hwcap.h:29: extern's make no sense in userspace
>
> Are you sure that this is safe for all user space? If a user application
> for instance includes asm/signal.h or asm/types.h from assembly (for
> whatever reason), it now breaks.
>
> I can't think of a good reason why anyone would do such a thing,
> but it used to be possible.
>

I also want to add :

__KERNEL__ and __ASSEMBLY__ is used for specific purpose, please do not
mix them otherwise it leads to confusion and people will start using
interchangeably. It seems to me that you are introducing Pink traffic
light for stoppage so my request is to respect the protocols.

I do not think it is safe and this will screw some user-space apps and
then later on kernel.

Thanks,
--
JSR