Re: [PATCH] X86: cpu_debug support for VIA / Centaur CPU's

[Jaswinder Singh Rajput <jaswinder@kernel.org>]

On Tue, 2009-06-09 at 22:53 +0800, Harald Welte wrote:
> Thanks for your quick response.
> 
> On Tue, Jun 09, 2009 at 02:23:18PM +0530, Jaswinder Singh Rajput wrote:
>  
> > On Tue, 2009-06-09 at 16:29 +0800, Harald Welte wrote:
> > > This patch adds the MSR definitions for the VIA/Centaur CPU models
> > > to cpu_debug.c
> > > 
> > > Signed-off-by: Harald Welte <HaraldWelte@viatech.com>
> > 
> > As per Ingo suggestion, we removed model information from cpu_debug and
> > is available in -tip :
> 
> but what happens if one MSR has a different group from vendor A to vendor B?
> and what happens if you read MSR's on a CPU that doesn't have them?  I suppose
> you get a segmentation fault, at least that's what I've received in the past
> when accidentially reading a MSR that doesn't exist.  Is that what the _safe_
> variant of rdmsr is for?
> 

AFAIK we are using safe variant. That's why I requested you to test
latest -tip and let us know your result and feedback.

> > 
> > Currently I am doing more changes and available in :
> > 
> > http://git.kernel.org/?p=linux/kernel/git/jaswinder/linux-2.6-cpu.git;a=shortlog;h=x86/cpu
> 
> Which means I should base on which of those tree to make sure it can be merged?
> 

-tip will be better option.

Thanks,
--
JSR