public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	markus.t.metzger@intel.com, tglx@linutronix.de, oleg@redhat.com,
	mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/core] x86, bts: reenable ptrace branch trace support
Date: Wed, 10 Jun 2009 14:44:03 +0200	[thread overview]
Message-ID: <1244637843.13761.11786.camel@twins> (raw)
In-Reply-To: <tip-7e0bfad24d85de7cf2202a7b0ce51de11a077b21@git.kernel.org>

On Thu, 2009-05-07 at 09:25 +0000, tip-bot for Markus Metzger wrote:
> Commit-ID:  7e0bfad24d85de7cf2202a7b0ce51de11a077b21
> Gitweb:     http://git.kernel.org/tip/7e0bfad24d85de7cf2202a7b0ce51de11a077b21
> Author:     Markus Metzger <markus.t.metzger@intel.com>
> AuthorDate: Fri, 24 Apr 2009 09:44:48 +0200
> Committer:  Ingo Molnar <mingo@elte.hu>
> CommitDate: Fri, 24 Apr 2009 10:18:51 +0200
> 
> x86, bts: reenable ptrace branch trace support
> 
> The races found by Oleg Nesterov have been fixed.
> 
> Reenable branch trace support.
> 
> Signed-off-by: Markus Metzger <markus.t.metzger@intel.com>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
> LKML-Reference: <20090424094448.A30216@sedona.ch.intel.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>

OK, this whole BTS thing worries me because it seems to expose too much
of the Intel Debug Store thingy to the outside world.

The thing is, once we do PEBS from inside the kernel, we'll have to
share the debug store, and the way this thing sets it up isn't really
going to work.

So what I'd like to see is having this debug store removed from the
interface and abstracted away as cpu resource -- a single page when in
use should suffice I think.

If you want to expose a buffer to userspace, use the regular mmap()
interface and fill those pages from the DS interrupt handler.

  reply	other threads:[~2009-06-10 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24  7:44 [patch] x86, bts: reenable ptrace branch trace support Markus Metzger
2009-05-07  9:25 ` [tip:tracing/core] " tip-bot for Markus Metzger
2009-06-10 12:44   ` Peter Zijlstra [this message]
2009-06-10 12:51     ` Ingo Molnar
2009-06-10 13:22       ` Metzger, Markus T
2009-06-10 13:29         ` Peter Zijlstra
2009-06-10 13:32           ` Metzger, Markus T
2009-06-10 13:43             ` Peter Zijlstra
2009-06-10 14:07               ` Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244637843.13761.11786.camel@twins \
    --to=peterz@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=markus.t.metzger@intel.com \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox